Skip to content

/ node

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: Remove reference to io.js #35618

Closed
wants to merge 1 commit into from
Closed

doc: Remove reference to io.js #35618

wants to merge 1 commit into from
+1 −2

Conversation

@hexxdump
Copy link
Contributor

@hexxdump hexxdump commented Oct 12, 2020 •
edited

doc: Remove reference to io.js

io.js is outdated, hence removed reference to it from docs.

Fixes:#35580

Signed-off-by: Hussaina Begum Nandyala hexxdump@gmail.com

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines
@hexxdump
Copy link
Contributor Author

@hexxdump hexxdump commented Oct 12, 2020

Please review
@aduh95 aduh95 requested review from antsmartian and gireeshpunathil Oct 12, 2020
@evanlucas
evanlucas approved these changes Oct 12, 2020
View changes
@gireeshpunathil
gireeshpunathil approved these changes Oct 13, 2020
View changes
@antsmartian
antsmartian approved these changes Oct 13, 2020
View changes
@Trott
Trott reviewed Oct 13, 2020
View changes
doc/api/process.md Outdated
@@ -1761,8 +1761,7 @@ tarball.

`process.release` contains the following properties:

* `name` {string} A value that will always be `'node'` for Node.js. For
legacy io.js releases, this will be `'io.js'`.
* `name` {string} A value that will always be `'node'` for Node.js.

This comment has been minimized.

Sign in to view
@Trott

Trott Oct 13, 2020
Member

Suggested change
* `name` {string} A value that will always be `'node'` for Node.js.
* `name` {string} A value that will always be `'node'`.
@Trott
Trott approved these changes Oct 13, 2020
View changes
@hexxdump
Copy link
Contributor Author

@hexxdump hexxdump commented Oct 14, 2020

@Trott @gireeshpunathil @antsmartian @evanlucas, can these changes be merged now ?
@jasnell
jasnell approved these changes Oct 14, 2020
View changes
@gireeshpunathil
Copy link
Member

@gireeshpunathil gireeshpunathil commented Oct 15, 2020

@hexxdump - are you able to make changes as @Trott suggested above? (basically remove for Node.js and push again)
@hexxdump
Remove reference to io.js
Loading status checks…
6250587 
Signed-off-by: Hussaina Begum Nandyala <hexxdump@gmail.com>
@hexxdump hexxdump force-pushed the hexxdump:master branch from b4ffe2f to 6250587 Oct 15, 2020
@hexxdump
Copy link
Contributor Author

@hexxdump hexxdump commented Oct 15, 2020

@gireeshpunathil, incorporated the changes suggested by @Trott
gireeshpunathil added a commit that referenced this pull request Oct 15, 2020
@hexxdump @gireeshpunathil
doc: Remove reference to io.js
Loading status checks…
4079bfd 
Signed-off-by: Hussaina Begum Nandyala <hexxdump@gmail.com>

PR-URL: #35618
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
@gireeshpunathil
Copy link
Member

@gireeshpunathil gireeshpunathil commented Oct 15, 2020

landed in 4079bfd . thanks for the contribution!
@hexxdump
Copy link
Contributor Author

@hexxdump hexxdump commented Oct 15, 2020

Thanks @gireeshpunathil, Its a very small change, I'm just getting started with OSS as part of Hacktoberfest. Will it be possible to mark this issue with 'hacktoberfest' label?
@gireeshpunathil
Copy link
Member

@gireeshpunathil gireeshpunathil commented Oct 15, 2020

I don't see that label anymore! @Trott - do you know?
@Trott
Copy link
Member

@Trott Trott commented Oct 15, 2020

To my knowledge, only https://github.com/nodejs/docker-node and https://github.com/nodejs/nodejs.dev are participating in Hacktoberfest. No other nodejs repos are participating (as far as I am aware).
@hexxdump
Copy link
Contributor Author

@hexxdump hexxdump commented Oct 22, 2020

To my knowledge, only https://github.com/nodejs/docker-node and https://github.com/nodejs/nodejs.dev are participating in Hacktoberfest. No other nodejs repos are participating (as far as I am aware).

No issues @Trott. I submitted another PR for Hactoberfest. Happy to see my first tiny commit in nodejs.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasnell jasnell

@evanlucas evanlucas

@Trott Trott

@antsmartian antsmartian

@gireeshpunathil gireeshpunathil

Assignees
No one assigned
Labels
doc process
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

7 participants
@hexxdump @gireeshpunathil @Trott @jasnell @evanlucas @antsmartian @nodejs-github-bot
You can’t perform that action at this time.