Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upGitHub is where the world builds software
Millions of developers and companies build, ship, and maintain their software on GitHub — the largest and most advanced development platform in the world.
feat(direnv): experimental SENTRY_PYTHON3 #19926
Merged
Conversation
EvanPurkhiser
force-pushed the
evanpurkhiser/featdirenv-support-python3-using-sentrypython3
branch
from
100b922
to
6043097
pyproject.toml
Outdated
| @@ -1,5 +1,5 @@ | |||
| [build-system] | |||
| requires = ["setuptools>=40.2.0", "wheel"] | |||
| requires = ["setuptools>=40.2.0,<46.0.0", "wheel"] | |||
EvanPurkhiser
Jul 21, 2020
Author
Member
Ok, I can't seem to reproduce this now, so just going to remove the constraint and see if it flares up later.
pyproject.toml
Outdated
| @@ -1,5 +1,5 @@ | |||
| [build-system] | |||
| requires = ["setuptools>=40.2.0", "wheel"] | |||
| requires = ["setuptools>=40.2.0,<46.0.0", "wheel"] | |||
joshuarli
changed the title
EvanPurkhiser
force-pushed the
evanpurkhiser/featdirenv-support-python3-using-sentrypython3
branch
from
6043097
to
4716126
EvanPurkhiser
force-pushed the
evanpurkhiser/featdirenv-support-python3-using-sentrypython3
branch
from
4716126
to
45e5dda
| venv_name=".venv" | ||
| python_version="python2.7" | ||
|
|
||
| if [ "$SENTRY_PYTHON3" = "1" ]; then |
joshuarli
Jul 21, 2020
Member
I'd just test that this env var is set to something. = 1 is unnecessarily strict. You missed changing the other places from x1, so might as well just hit 2 birds with 1 stone there.
EvanPurkhiser
Jul 21, 2020
Author
Member
hmm, I would prefer some kind of truthy check, otherwise if you set it to 0 it will still work.
EvanPurkhiser
force-pushed the
evanpurkhiser/featdirenv-support-python3-using-sentrypython3
branch
from
45e5dda
to
1748ea8
EvanPurkhiser
merged commit 27a27bf
into
master
11 of 12 checks passed
11 of 12 checks passed
EvanPurkhiser
deleted the
evanpurkhiser/featdirenv-support-python3-using-sentrypython3
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
direnvnow supports a python3 environment by setting theSENTRY_PYTHON3flag.This uses the
.venv3directory for the virtual env. This makes the assumption that we'll have our tooling support both.venvand.venv3.If we don't want to do this, I can definitely have it do some fancy symlink things. But I suspect symlinks are going to cause us more trouble than we might expect.