Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upGitHub is where the world builds software
Millions of developers and companies build, ship, and maintain their software on GitHub — the largest and most advanced development platform in the world.
style: Remove trailing slash from static symlink #10045
Merged
Conversation
EvanPurkhiser
changed the title
This is very minor, but when symlinking a directory the trailing slash is not needed and makes the output of `ls -l --classify` look a little funny. $ ls -l --classify lrwxr-xr-x 1 evan staff 24 Oct 8 16:25 static -> src/sentry/static/sentry// Where as with it removed it does not have the trailing slash: $ ls -l --classify lrwxr-xr-x 1 evan staff 24 Oct 8 16:25 static -> src/sentry/static/sentry/ Semantically it doesn't seem important [0]. [0]: https://unix.stackexchange.com/questions/7769/should-i-include-a-trailing-slash-in-a-symlink-to-a-directory
EvanPurkhiser
force-pushed the
style-remote-trailing-slash-from-static-symlink
branch
to
974ba8a
EvanPurkhiser
merged commit 22e96f9
into
master
6 checks passed
6 checks passed
license/snyk - package.json (sentry)
No manifest changes detected
security/snyk - package.json (sentry)
No manifest changes detected
cjmaio
added a commit
to cjmaio/sentry
that referenced
this pull request
Dec 17, 2018
This is very minor, but when symlinking a directory the trailing slash is not needed and makes the output of `ls -l --classify` look a little funny. $ ls -l --classify lrwxr-xr-x 1 evan staff 24 Oct 8 16:25 static -> src/sentry/static/sentry// Where as with it removed it does not have the trailing slash: $ ls -l --classify lrwxr-xr-x 1 evan staff 24 Oct 8 16:25 static -> src/sentry/static/sentry/ Semantically it doesn't seem important [0]. [0]: https://unix.stackexchange.com/questions/7769/should-i-include-a-trailing-slash-in-a-symlink-to-a-directory
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
This is very minor, but when symlinking a directory the trailing slash is not needed and makes the output of
ls -l --classifylook a little funny.$ ls -l --classify
lrwxr-xr-x 1 evan staff 24 Oct 8 16:25 static -> src/sentry/static/sentry//
Where as with it removed it does not have the trailing slash:
$ ls -l --classify
lrwxr-xr-x 1 evan staff 24 Oct 8 16:25 static -> src/sentry/static/sentry/
Semantically it doesn't seem important.