Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add extension point to OnFlyCallGraphBuilder for handling special cases #1064

Open
mbenz89 opened this issue Nov 14, 2018 · 0 comments
Open

Add extension point to OnFlyCallGraphBuilder for handling special cases #1064

mbenz89 opened this issue Nov 14, 2018 · 0 comments

Comments

@mbenz89
Copy link
Contributor

@mbenz89 mbenz89 commented Nov 14, 2018

When generating a call graph, SPARK has to handle many special cases for concurrency helper classes like java.lang.Thread or android.os.AsyncTask. These classes usually have control flow properties hidden to the call graph analysis, e.g., the Thread's Thread.run method will be invoked asynchronously after calling Thread.start or AsyncTask.onPostExecute will be executed after AsyncTask.doInBackground has finished. SPARK handles these cases by building an artifical short circuit between these framework managed calls, i.e., it adds edges between the start, computation and epilogue methods of these concurrecy helper classes to the call graph.

Currently, these special cases are hard coded into the OnFlyCallGraphBuilder class.

OnFlyCallGraphBuilder needs an extension point which is capable of handling such special cases. Handling of concurrency helper classes and other special cases should then be removed from OnFlyCallGraphBuilder and encapsulated in implementations of the extension point.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
1 participant
You can’t perform that action at this time.