Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upRefactor fallback' read header #441
Open
Conversation
…available MessagePack types.
…ll '_unpack()' method on a single byte.
Codecov Report
@@ Coverage Diff @@
## master #441 +/- ##
==========================================
+ Coverage 88.07% 88.34% +0.27%
==========================================
Files 5 5
Lines 847 738 -109
==========================================
- Hits 746 652 -94
+ Misses 101 86 -15
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
I reordered the code in the
_read_header()method of thefallback.pyfile.I removed duplicated code and (hopefully) made the function more readable and maintainable.