Skip to content

/ pandas

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TST: split up test_concat.py #37243

Open
jreback opened this issue Oct 19, 2020 · 2 comments · May be fixed by #37259
Open

TST: split up test_concat.py #37243

jreback opened this issue Oct 19, 2020 · 2 comments · May be fixed by #37259
Assignees
@laffite56
Labels
Testing good first issue
Milestone
Contributions Wel...

Comments

@jreback
Copy link
Contributor

@jreback jreback commented Oct 19, 2020

we should split this to a sub-module (concat) and then split logically (similar to merge)

https://github.com/pandas-dev/pandas/blob/master/pandas/tests/reshape/test_concat.py
@jreback jreback added this to the Contributions Welcome milestone Oct 19, 2020
@laffite56
Copy link

@laffite56 laffite56 commented Oct 19, 2020

Hello,
i want contribute to this issue. I am not completely sure about files content, so let me know if I need to change something. I will make PR in about 30 minutes.
@laffite56
Copy link

@laffite56 laffite56 commented Oct 19, 2020

take
laffite56 added a commit to laffite56/pandas that referenced this issue Oct 19, 2020
@laffite56
TST: split up test_concat.py pandas-dev#37243
e03efd1
@jreback jreback linked a pull request that will close this issue Oct 20, 2020
Open
0 of 5 tasks complete
laffite56 added a commit to laffite56/pandas that referenced this issue Oct 20, 2020
@laffite56
TST: split up test_concat.py pandas-dev#37243
75d49cf
laffite56 added a commit to laffite56/pandas that referenced this issue Oct 20, 2020
@laffite56
TST: split up test_concat.py pandas-dev#37243
f259227
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@laffite56 laffite56

Labels
Testing good first issue
Projects
None yet
Milestone
Contributions Wel...
Linked pull requests

Successfully merging a pull request may close this issue.

TST: split up test_concat.py #37243
2 participants
@jreback @laffite56
You can’t perform that action at this time.