Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix branch menu on unborn branch #2213

Merged
merged 5 commits into from Jul 22, 2019
Merged

Fix branch menu on unborn branch #2213

merged 5 commits into from Jul 22, 2019

Conversation

@smashwilson
Copy link
Member

smashwilson commented Jul 19, 2019

Please be sure to read the contributor's guide to the GitHub package before submitting any pull requests.

Requirements

  • Filling out the template is required. Any pull request that does not include enough information to be reviewed in a timely manner may be closed at the maintainers' discretion.
  • Suggestion: You can use checklists to keep track of progress for the sections on metrics, tests, documentation, and user research.

Description of the Change

If you open Atom in a repository after you run git init . but before you make your first commit, the "branch menu" selector is blank, which looks wrong and is difficult to interact with. I've changed it to show "no branch" instead.

Screenshot/Gif

Before After
before-status-bar after-status-bar
before-menu after-menu

Alternate Designs

N/A

Benefits

Users who initialize a repo from Atom will be less confused.

Possible Drawbacks

N/A

Applicable Issues

N/A

Metrics

N/A

Tests

I opened Atom on a repo I'd just initialized.

Documentation

N/A

Release Notes

  • The branch menu displays "no branch" on a repository that's just been initialized.

User Experience Research (Optional)

N/A

smashwilson added 3 commits Jul 19, 2019
@smashwilson smashwilson requested review from kuychaco and vanessayuenn Jul 19, 2019
@smashwilson smashwilson added this to In progress in Release : v0.31.0 Jul 19, 2019
@codecov
Copy link

codecov bot commented Jul 19, 2019

Codecov Report

Merging #2213 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2213      +/-   ##
==========================================
+ Coverage    92.7%   92.71%   +<.01%     
==========================================
  Files         216      216              
  Lines       12352    12347       -5     
  Branches     1814     1815       +1     
==========================================
- Hits        11451    11447       -4     
+ Misses        901      900       -1
Impacted Files Coverage Δ
lib/views/branch-menu-view.js 97.72% <100%> (+5.89%) ⬆️
lib/models/repository.js 96.35% <100%> (ø) ⬆️
lib/models/operation-states.js 89.58% <0%> (-2.09%) ⬇️
lib/helpers.js 88.47% <0%> (-0.42%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5db1eed...095897e. Read the comment docs.

smashwilson added 2 commits Jul 20, 2019
@smashwilson smashwilson merged commit 912d217 into master Jul 22, 2019
9 checks passed
9 checks passed
Consider pull request for release board Consider pull request for release board
Details
atom.github Build #20190721.10 succeeded
Details
atom.github (Lint) Lint succeeded
Details
atom.github (Linux) Linux succeeded
Details
atom.github (MacOS) MacOS succeeded
Details
atom.github (Snapshot) Snapshot succeeded
Details
atom.github (Windows) Windows succeeded
Details
codecov/patch 100% of diff hit (target 92.7%)
Details
codecov/project 92.71% (+<.01%) compared to feef991
Details
Release : v0.31.0 automation moved this from In progress to Merged Jul 22, 2019
@smashwilson smashwilson deleted the aw/branch-menu branch Jul 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Linked issues

Successfully merging this pull request may close these issues.

None yet

1 participant
You can’t perform that action at this time.