Skip to content

/ react-weui

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: issue 320 #322

Merged
merged 4 commits into from Jul 23, 2020
Merged

fix: issue 320 #322

merged 4 commits into from Jul 23, 2020

Conversation

@z2014
Copy link
Collaborator

@z2014 z2014 commented Jul 22, 2020

fix issue 320
z2014
fix: issue 320
Loading status checks…
a4e60de
@aquariuslt
aquariuslt reviewed Jul 22, 2020
View changes
src/components/dialog/dialog.js Outdated Show resolved Hide resolved
@aquariuslt
fix(dialog) resolve lint issue src/components/dialog/dialog.js
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
253822e
@aquariuslt
aquariuslt reviewed Jul 22, 2020
View changes
src/components/dialog/dialog.js Outdated Show resolved Hide resolved
@aquariuslt
fix(dialog): resolve test issue src/components/dialog/dialog.js
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
4799938
@aquariuslt aquariuslt dismissed their stale review Jul 22, 2020

applied

@aquariuslt
aquariuslt approved these changes Jul 22, 2020
View changes
Copy link
Collaborator

@aquariuslt aquariuslt left a comment

LGTM
@ettingshausen
ettingshausen approved these changes Jul 22, 2020
View changes
@z2014
feat: update version 1.2.3
Loading status checks…
dcc929b
@z2014 z2014 merged commit 494113a into weui:master Jul 23, 2020
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@z2014 z2014 mentioned this pull request Jul 23, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aquariuslt aquariuslt

@ettingshausen ettingshausen

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
@z2014 @aquariuslt @ettingshausen
You can’t perform that action at this time.