Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor complimentary plans #170

Open
wants to merge 3 commits into
base: master
from

Conversation

@allouis
Copy link
Collaborator

@allouis allouis commented Jun 24, 2020

closes #168

This updates the setComplimentarySubscription to use the Price's API to give members a 0 cost subscription. It also adds complimentary: true to the subscription metadata, and ensures the "plans name" is stored as "Complimentary" to reduce the changes needed in the Admin

@allouis allouis requested a review from naz Jun 24, 2020
@allouis
Copy link
Collaborator Author

@allouis allouis commented Jun 24, 2020

We still need some work in Ghost to remove references to the Complimentary plans, as well as bumping the version when this is merged.

@allouis allouis mentioned this pull request Jun 24, 2020
2 of 7 tasks complete
allouis added 2 commits Jun 12, 2020
no-issue

This gives us access to the 'price' object in Stripe
no-issue

This is the latest version and gives us access to the 'price' api &
resource
@allouis allouis force-pushed the allouis:refactor-complimentary-plans branch from 8c8ec42 to aaeef4a Jun 24, 2020
no-issue

This updates the setComplimentarySubscription to use the Price's API to
give members a 0 cost subscription. It also adds complimentary: true to
the subscription metadata, and ensures the "plans name" is stored as
"Complimentary" to reduce the changes needed by clients
@allouis allouis marked this pull request as ready for review Jun 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

1 participant
You can’t perform that action at this time.