Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Concord theme: Invisible send button #2274

Closed
Zash opened this issue Oct 6, 2020 · 0 comments
Closed

Concord theme: Invisible send button #2274

Zash opened this issue Oct 6, 2020 · 0 comments

Comments

@Zash
Copy link
Contributor

@Zash Zash commented Oct 6, 2020

Describe the bug
When using the 'concord' theme, the button to send messages is a white icon on white background.

To Reproduce
Steps to reproduce the behavior:

  1. Configure concord theme
  2. Open a chat
  3. Look for send button

Expected behavior
Button should match the colors of the theme, i.e. gray on white, gray and white (which should be which of these left to the concord theme designer). Compare the << icon in attached screenshots.

Screenshots

image

image

Environment (please complete the following information):

  • Debian 10 desktop
  • Firefox ?? ESR
  • Converse.js version almost 7 f68eb65 (might be a few commits earlier actually)

Additional context
Spotted a color: #fff !important in the browser DOM inspector tool which appears to come from:

converse.js/sass/_core.scss

Lines 392 to 396 in f68eb65

.btn {
font-weight: normal;
color: #fff;
.fa, .far, .fas {
color: #fff;

@jcbrand jcbrand added this to the 7.0.0 milestone Oct 7, 2020
bernard-ng added a commit to bernard-ng/converse.js that referenced this issue Oct 8, 2020
bernard-ng added a commit to bernard-ng/converse.js that referenced this issue Oct 15, 2020
bernard-ng added a commit to bernard-ng/converse.js that referenced this issue Oct 15, 2020
jcbrand pushed a commit that referenced this issue Oct 15, 2020
use muc-toolbar-btn-color for background
muppeth added a commit to muppeth/converse.js that referenced this issue Oct 16, 2020
@jcbrand jcbrand closed this Oct 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.