Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port to cryptography. #288

Draft
wants to merge 1 commit into
base: master
from
Draft

Conversation

@tomprince
Copy link

@tomprince tomprince commented Sep 9, 2020

No description provided.

@sonarcloud
Copy link

@sonarcloud sonarcloud bot commented Sep 9, 2020

SonarCloud Quality Gate failed.

Bug E 1 Bug
Vulnerability E 6 Vulnerabilities (and Security Hotspot 1 Security Hotspot to review)
Code Smell A 1 Code Smell

No Coverage information No Coverage information
0.0% 0.0% Duplication

@rossengeorgiev
Copy link
Contributor

@rossengeorgiev rossengeorgiev commented Sep 9, 2020

Thanks, but in v1.0.0 I specifically moved away from cryptography, because it made installation more error prone. See b31354f, and even you go further back you can find the move to cryptography before that #17

@rossengeorgiev
Copy link
Contributor

@rossengeorgiev rossengeorgiev commented Sep 11, 2020

Potentially, both could be supported with cryptography being preferred (should have better performance) if available. Also, have it as an extra in setup.py

@tomprince
Copy link
Author

@tomprince tomprince commented Sep 16, 2020

I'm curious what kind of errors you are getting installing cryptography? I know the maintainers of it, and I know they spend a bunch of effort to ensure that there are wheels for all major platforms, so that installation shouldn't be an issue. I think the only semi-common platform they don't provide wheels for is alpine linux (and I suspect that is largely because there isn't a good standard of how to build compatible wheels; see pypa/manylinux#37 for example).

@rossengeorgiev
Copy link
Contributor

@rossengeorgiev rossengeorgiev commented Sep 16, 2020

It was long time ago, and I can't recall specifics. But it made installs slow and error prone due compilation step or having to install various libraries. Cygwin was painful, and I recall issues with linux and windows installs. The switch to pycryptodome was solely to get rid of these issues.

I've thought before about simply having both, and preferring cryptography if its available. Best of both worlds.

@tomprince
Copy link
Author

@tomprince tomprince commented Sep 16, 2020

due compilation step or having to install various libraries

That should no longer be necessary; cryptography added manylinux wheels in v2.0 (2017), which will be used by any recent version of pip (>8.1; 2016). (Although there aren't cygwin wheels).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.