Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

provide a basic GUI for users who prefer to uses GUI #17

Open
nidhaloff opened this issue Sep 21, 2020 · 13 comments
Open

provide a basic GUI for users who prefer to uses GUI #17

nidhaloff opened this issue Sep 21, 2020 · 13 comments

Comments

@nidhaloff
Copy link
Owner

@nidhaloff nidhaloff commented Sep 21, 2020

Description

Users should have the flexibility of using a simple GUI if they don't want to use the CLI. A simple GUI can be made with Tkinter maybe?
It's important to not add any dependency for this. It would be better to implement this using an existing python module.

@dinhanhx
Copy link
Contributor

@dinhanhx dinhanhx commented Sep 23, 2020

I suggest that we (everyone who read this issue) add a command to trigger GUI, some things like igel -g or igel -gui.

@nidhaloff
Copy link
Owner Author

@nidhaloff nidhaloff commented Sep 23, 2020

well said. I like the idea of igel gui. If you like this feature and find it exciting, you can work on it ;)

@dinhanhx
Copy link
Contributor

@dinhanhx dinhanhx commented Sep 24, 2020

The GUI should have:

  • TKinter entries for parameter of .yaml file
  • TKinter buttons to import, export, fit, evaluate, predict, experiment, help. For help button I think it will open igel doc to reduce work for anyone who make, contribute, maintain this part.

Note: Import, export .yaml files

@nidhaloff
Copy link
Owner Author

@nidhaloff nidhaloff commented Sep 24, 2020

@dinhanhx I don't mind that ;) However, I was thinking that a yaml file will not be needed in the gui funtionality. Instead, the user can upload the data as csv (or maybe enter the path to the data), select the model he wants to use (from a select button with multiple items) and then click ok. This were my thoughts but It's flexible ;)

@dinhanhx
Copy link
Contributor

@dinhanhx dinhanhx commented Sep 24, 2020

Your idea is more user-friendly than mine

@nidhaloff
Copy link
Owner Author

@nidhaloff nidhaloff commented Sep 27, 2020

@dinhanhx please tell me If you are working or want to work on this in order to clarify the state of this feature ;)

@dinhanhx
Copy link
Contributor

@dinhanhx dinhanhx commented Sep 27, 2020

@nidhaloff I want to work on this feature but I am quite busy with university work at the moment

@peter-shoes
Copy link

@peter-shoes peter-shoes commented Sep 29, 2020

I could write something up for this using a basic tkinter UI, but there seem to be quite a few available options under read_data_options. Perhaps something like a button that allows you to add another data option from a dropdown?

@nidhaloff
Copy link
Owner Author

@nidhaloff nidhaloff commented Sep 29, 2020

@peter-shoes Thanks for joining the project. Yes a drop-down menu was also what I thought about. I think that would be great, otherwise you can be creative as you want ;)

@peter-shoes
Copy link

@peter-shoes peter-shoes commented Sep 29, 2020

@nidhaloff I started working by hardcoding the options, but it occurred to me that you might wanna update things in the future. I was able to find options for "type", "split", "preprocess", "model", and "target" in the code to pull from, but there is nothing referencing any of the "read_data_options". Should these just be hardcoded?

@nidhaloff
Copy link
Owner Author

@nidhaloff nidhaloff commented Sep 30, 2020

@peter-shoes You mean default values? you are right. I provided default values for "split", "preprocess" etc.. but I didn't do that for read_data_options yet since it's a new feature that I implemented this week. The read_data_options are basically the arguments that will be given to the read_csv function of pandas. Check it out here

@peter-shoes
Copy link

@peter-shoes peter-shoes commented Oct 1, 2020

@nidhaloff just an update! i've been working on this and i think i'll just do the one pull request when i've completed it. i'm taking strings from the readme in order to get these massive lists of options for "model_type" and "read_data_options". should be done by the weekend probably?

@nidhaloff
Copy link
Owner Author

@nidhaloff nidhaloff commented Oct 1, 2020

@peter-shoes Alright cool. Happy coding ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants
You can’t perform that action at this time.