Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upRemove Request pass through methods #1396
Comments
|
It looks like these are aliased, is there a compelling reason for removing them all as opposed to fixing the plugin? I'm |
|
@retrohacker - I would suggest that the query parser behaviour of setting For me aliases are a fine for keeping backward compatibility for semvar minor release but should be removed when doing a semvar major release. The Restify v5 release contains a number of API changes so I don't see the problem in doing a bit of code maintenance. |
|
Met the same question, I am using node6.9.4, express 4.3.0 and restify 5.0.0, restify will make request.query to be a function, so that express can't parse the query string any more, because it's not null(express.middleware.query.js 39). And it broke down my project. Restify 4.3.0 works fine. |
|
Marking this as ready to implement, as it would be nice to have compatibility with express. @yunong and @DonutEspresso, chime in if you disagree. |
|
I suspect many of the aliases are from before they existed in node core. Agree - it makes sense to use the now native methods where possible. |
|
Related: #1422 |
|
Related: #1529 |
|
Hello, I am starting to work on this and i understand the problem. I will explain what i understand of the problem and you can correct me if i am wrong.
Please confirm my thoughts. I apologise in advance if I sound ignorant at some places as this is my first stab in open source world and i am not a Rockstar in javascript as well. Thank You |
Feature Request
Use Case
Remove the pass through methods on
Requestto make the API more consistent as well as fix a bug whereres.query()is overwritten byres.querywhen using the queryParser plugin.Now is the time to do this as part of the v5 release.
Example API
Remove the following API endpoints.
Are you willing and able to implement this?
Yes