Skip to content

Update readme.md #1837

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 2, 2020
Merged

Update readme.md #1837

merged 1 commit into from
Oct 2, 2020

Conversation

ChaosEx
Copy link
Contributor

@ChaosEx ChaosEx commented Oct 1, 2020

  • Added links to their respective Github profile to all the people mentioned in the acknowledgments

  • It is easier to look up for them with a single click

  • Have you followed the contributing guidelines?

  • Have you explained what your changes do, and why they add value to the Guides?

Please note: we will close your PR without comment if you do not check the boxes above and provide ALL requested information.


Added links to their respective github profile to all the people mentioned in the acknowledgments
@ChaosEx ChaosEx requested a review from a team October 1, 2020 06:30
Copy link
Contributor

@deniseyu deniseyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏼

@deniseyu deniseyu merged commit e9d421a into github:main Oct 2, 2020

## Disclaimer
While we've got advice about running an open source project, we're not lawyers. Be sure to read our [disclaimer](notices.md#legal-disclaimer) before diving in.

[1]:https://github.com/nayafia
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pro tip: doing

-[1]: https://github.com/nayafia
+[@nayafia]: https://github.com/nayafia

would've allowed using just [@nayafia] in the text instead of [@nayafia][1]. FYI.

@explor22

This comment has been minimized.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants