-
Notifications
You must be signed in to change notification settings - Fork 21
Add a mini-language parser for generic GQL list filtering #305
Conversation
Codecov Report
@@ Coverage Diff @@
## master #305 +/- ##
==========================================
+ Coverage 49.42% 50.57% +1.15%
==========================================
Files 42 46 +4
Lines 6503 7786 +1283
==========================================
+ Hits 3214 3938 +724
- Misses 3289 3848 +559
Continue to review full report at Codecov.
|
|
While I'm reviewing, please sign up the CLA and fix up the style issues indicated by lint checkers. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please check out the comments.
Also, where are the code changes for GQL list queries in other modules of ai.backend.manager.models?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall, LGTM about fulfilling my functional requirements.
Since your internship has finished, I will do some style/code clean up.
…e given query object
|
Now we need to use |
|
I will file a new issue for the application of |
Defined a method to change the query statement to sql statement.