Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configure the server to listen on a unix socket #237

Open
GustavGenberg opened this issue Nov 5, 2019 · 4 comments
Open

Configure the server to listen on a unix socket #237

GustavGenberg opened this issue Nov 5, 2019 · 4 comments

Comments

@GustavGenberg
Copy link

@GustavGenberg GustavGenberg commented Nov 5, 2019

Is your feature request related to a problem? Please describe.
No

Describe the solution you'd like
A way of configuring the server to listen on a unix socket.
For example you could join the listenaddr and the port into a
single option called listen. Then the listen option could either
get passed localhost:1234 or unix:/tmp/gotify.sock.

Describe alternatives you've considered
n/a

Additional context
n/a

@jmattheis
Copy link
Member

@jmattheis jmattheis commented Nov 5, 2019

Do you have a specific use-case for this? This would be a breaking change which would require manual intervention of the user.

@GustavGenberg
Copy link
Author

@GustavGenberg GustavGenberg commented Nov 5, 2019

I am currently running many different applications behind an nginx reverse proxy. By having the applications listen on a unix socket, I do not have to deal with a ton of different ports (aswell as there is a tiny performance gain). Therefore using the same structure for Gotify makes sense to me.

Maybe the listen option could override the listenaddr and port options, thus making the update backwards-compatible.

@sik0vny
Copy link

@sik0vny sik0vny commented May 5, 2020

I would also like that for cleaner connection with nginx

@schneidersoft
Copy link

@schneidersoft schneidersoft commented Oct 18, 2020

I also have this situation. I use nginx to handle ssh stuff and reverse proxy gotify.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
4 participants
You can’t perform that action at this time.