Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ctl check: check if two bot use the same cache db #1316

Open
wagner-certat opened this issue Sep 5, 2018 · 1 comment
Open

ctl check: check if two bot use the same cache db #1316

wagner-certat opened this issue Sep 5, 2018 · 1 comment

Comments

@wagner-certat
Copy link
Member

@wagner-certat wagner-certat commented Sep 5, 2018

Idea for the intelmqctl check method:

Check if there are two bots which use the same redis cache database, issue a warning if this is the case. Bots should use the databases >= 10.

@wagner-certat wagner-certat added this to the 1.2.0 milestone Sep 5, 2018
@wagner-certat wagner-certat modified the milestones: 1.2.0, 2.0.0, 2.1.0 Apr 9, 2019
@wagner-certat wagner-certat modified the milestones: 2.1.0, 2.2.0 Oct 25, 2019
@wagner-certat
Copy link
Member Author

@wagner-certat wagner-certat commented Jun 17, 2020

Can easily lead to false positives, especially with multiple instances of the same bot.

Maybe instead only check that no two different bot modules use the same database, e.g. two completely different experts should not use the same DB, but two deduplicators are allowed to use the same one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
1 participant
You can’t perform that action at this time.