Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Remove octicon things #33

Merged
merged 2 commits into from Sep 14, 2020
Merged

feat: Remove octicon things #33

merged 2 commits into from Sep 14, 2020

Conversation

@JasonEtco
Copy link
Contributor

@JasonEtco JasonEtco commented Sep 14, 2020

We've now moved all of the Octicon handling to be a Liquid tag, which is located in the repository of docs.github.com. This helps us reduce the amount of times we have to parse through a big string. For the Hubbers who can see it, that tag was added here: github/docs-internal#15170

This PR removes all references to Octicons in this library 🔪 This'll be a breaking change, since we remove a piece of functionality from the library.

@JasonEtco JasonEtco requested a review from zeke Sep 14, 2020
@JasonEtco JasonEtco changed the title Remove octicon things feat: Remove octicon things Sep 14, 2020
@zeke
zeke approved these changes Sep 14, 2020
Copy link
Member

@zeke zeke left a comment

👌🏼

@zeke zeke merged commit b25a97f into master Sep 14, 2020
5 checks passed
5 checks passed
build (ubuntu-latest, 10.x)
Details
build (ubuntu-latest, 12.x)
Details
build (windows-latest, 10.x)
Details
build (windows-latest, 12.x)
Details
Semantic Pull Request ready to be squashed
Details
@zeke zeke deleted the remove-octicon-things branch Sep 14, 2020
@zeke
Copy link
Member

@zeke zeke commented Sep 14, 2020

squashed with a BREAKING CHANGE: prefix in the extended body 🤞🏼

@github-actions
Copy link

@github-actions github-actions bot commented Sep 14, 2020

🎉 This PR is included in version 4.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions github-actions bot added the released label Sep 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.