Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upFix crashes when editing wide characters spanning 2 `u16`s (UTF-16) #1112
+141
−20
Conversation
Xanewok
changed the title
|
Just noticed one caveat, will need to fix that before it lands. |
|
With rust-lang/rfcs#2457 merged we additionally now have to be careful around Unicode identifiers and their, currently wrong, (ノ ゜Д゜)ノ ︵ ┻━┻
UTF-16 is a can of worms. While this PR fixes an unrecoverable crash and possible text buffer corruption, the remaining UTF-16 Range thing is mostly displaying diagnostics, so I'd treat it with a lower priority (but still something that we need to fix!). |
|
Looks good, thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Blocked on rust-dev-tools/rls-vfs#24.Fixes #1104.
r? @nrc