Skip to content

/ cachecontrol

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix!: typos #17

Merged
merged 1 commit into from Sep 21, 2020
Merged

fix!: typos #17

merged 1 commit into from Sep 21, 2020

Conversation

@dunglas
Copy link
Contributor

@dunglas dunglas commented Sep 20, 2020

Fix some typos.
The change in ReasonRequestMethodUnknown is a BC break.

Also, "cachable" is more often written "cacheable", maybe should we change this too, but it's a bigger BC break.
@dunglas
fix!: typos
Verified
This commit was signed with a verified signature.
dunglas Kévin Dunglas
GPG key ID: 9D0C5D6EEB42C445 Learn about signing commits
Loading status checks…
23aa536
@dunglas dunglas force-pushed the dunglas:fix/typos branch from 3e53c73 to 23aa536 Sep 20, 2020
@pquerna
pquerna approved these changes Sep 21, 2020
View changes
Copy link
Owner

@pquerna pquerna left a comment

Thank you for the PR.

While renaming ReasonRequestMethodUnknown break the ABI, I think given I can't find any public code bases referencing it directly, its a quick/small fix on upgrade that is easy to do, lets do it.
@pquerna pquerna merged commit 858c6e7 into pquerna:master Sep 21, 2020
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@dunglas dunglas deleted the dunglas:fix/typos branch Sep 22, 2020
@dunglas
Copy link
Contributor Author

@dunglas dunglas commented Sep 22, 2020

And what do you think about cachable vs cacheable?
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pquerna pquerna

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
@dunglas @pquerna
You can’t perform that action at this time.