Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle c++17 nested namespaces in gmock generation #2824

Open
wants to merge 1 commit into
base: master
from

Conversation

@xwl
Copy link

xwl commented Apr 24, 2020

No description provided.

@googlebot
Copy link

googlebot commented Apr 24, 2020

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@googlebot googlebot added the cla: no label Apr 24, 2020
@vslashg vslashg self-assigned this Apr 28, 2020
@vslashg
Copy link
Member

vslashg commented May 12, 2020

We are not opposed to investigating this change, but you will need to sign the CLA.

@xwl
Copy link
Author

xwl commented May 13, 2020

@googlebot I signed it!

@googlebot
Copy link

googlebot commented May 13, 2020

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@googlebot googlebot added cla: yes and removed cla: no labels May 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.