Skip to content

/ libra

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[backup] refine s3 sample config #6045

Open
wants to merge 1 commit into
base: master
from
Open

[backup] refine s3 sample config #6045

wants to merge 1 commit into from
+23 −6

Conversation

@msmouse
Copy link
Contributor

msmouse commented Sep 16, 2020

Motivation

  1. deal with the case where metadata folder doesn't exist when listing metadata files (otherwise for an empty backup storage, one need to manually create the folder)
  2. break commands to multiple lines and add comments

Have you read the Contributing Guidelines on pull requests?

Y

Test Plan

testnet

Related PRs
@msmouse msmouse requested a review from lightmark Sep 16, 2020
@bors-libra bors-libra added this to In Review in bors Sep 16, 2020
@libra-cla-bot libra-cla-bot bot added the cla-signed label Sep 16, 2020
@msmouse
[backup] refine s3 sample config
Loading status checks…
d9a4866 
1. deal with the case where metadata folder doesn't exist when listing metadata files (otherwise for an empty backup storage, one need to manually create the folder)
2. break commands to multiple lines and add comments
@msmouse msmouse force-pushed the msmouse:s3_sample_refine branch from 948ed58 to d9a4866 Sep 16, 2020
@lightmark
lightmark approved these changes Sep 16, 2020
View changes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lightmark lightmark

Assignees
No one assigned
Labels
cla-signed
Projects
bors
In Review
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
@msmouse @lightmark
You can’t perform that action at this time.