Skip to content

/ xterm.js

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support callback as bellSound #3014

Open
Tyriar opened this issue Jul 16, 2020 · 2 comments
Open

Support callback as bellSound #3014

Tyriar opened this issue Jul 16, 2020 · 2 comments
Labels
good first issue help wanted type/enhancement

Comments

@Tyriar
Copy link
Member

@Tyriar Tyriar commented Jul 16, 2020

Electron has an API to play the shell bell https://www.electronjs.org/docs/api/shell#shellbeep

To support this with xterm.js we would need to allow bellSound to take a () => void:

xterm.js/typings/xterm.d.ts

Lines 47 to 50 in ab63b51

/**
* A data uri of the sound to use for the bell when `bellStyle = 'sound'`.
*/
bellSound?: string;

@Tyriar Tyriar mentioned this issue Jul 16, 2020
Open
@bolariin
Copy link

@bolariin bolariin commented Aug 2, 2020

I would like to work on this issue
@Tyriar
Copy link
Member Author

@Tyriar Tyriar commented Aug 3, 2020

@bolariin sounds good 👍
@QuiiBz QuiiBz mentioned this issue Sep 13, 2020
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue help wanted type/enhancement
Milestone
No milestone
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
@Tyriar @bolariin
You can’t perform that action at this time.