Skip to content

/ VisualStudio

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Error when adding PR comments with GitHub Enterprise #2486

Open
blkbam opened this issue Mar 27, 2020 · 7 comments
Open

Error when adding PR comments with GitHub Enterprise #2486

blkbam opened this issue Mar 27, 2020 · 7 comments
Projects
GitHub Enterprise

Comments

@blkbam
Copy link

@blkbam blkbam commented Mar 27, 2020

Versions

  • GitHub Enterprise: 2.20.3.
  • GitHub Extension for Visual Studio version: 2.11.89.33912
  • Visual Studio version: Microsoft Visual Studio Professional 2019
    Version 16.5.1
    VisualStudio.16.Release/16.5.1+29920.165
    Microsoft .NET Framework
    Version 4.8.03752

What happened

We are using GitHub Enterprise. After updating the plugin to 2.11.89.33912, when attempting to add a comment to a Pull Request, an error occurs and the comment is not added to the line of code.

Steps to Reproduce

Steps to reproduce the behavior:

  1. In Visual Studio, Go to the GitHub plugin window.
  2. Open an existing pull request
  3. Open any file within the pull request
  4. Scroll until a line with a change is available then click plus button in the left margin to open a comment box.
  5. Add text to the box.
  6. Click either "Add a single comment" or "Start a review".
  7. See the error appear below the box: InvalidObject 'AddPullRequestReviewCommentInput' doesn't accept argument 'pullRequestId'

Expected behavior

The "Add a single comment" and "Start a review" buttons should save the comment to the line of code then perform their respective actions.

Screenshots

AddPullRequestReviewCommentInput_error

Logs

Additional context

This issue doesn't occur in 2.10.8.8121.
@jcansdale jcansdale added this to To do in GitHub Enterprise Mar 29, 2020
@MilosAuder
Copy link

@MilosAuder MilosAuder commented Apr 3, 2020

We have this exact same problem, so it's basically unusable anymore.
@silviofuchs
Copy link

@silviofuchs silviofuchs commented Apr 24, 2020

I have the same issue.
Microsoft Visual Studio Professional 2019 Version 16.5.4
Microsoft .NET Framework Version 4.8.03761
GitHub.VisualStudio 2.11.96.24460
@waynebsx
Copy link

@waynebsx waynebsx commented Apr 24, 2020

Same after updating extension to latest.
Microsoft Visual Studio Professional 2019 Version 16.5.4
@VladRoblox
Copy link

@VladRoblox VladRoblox commented May 4, 2020

Same
@janecosham
Copy link

@janecosham janecosham commented May 28, 2020

We have this problem too - using Github Enterprise 2.19.3
Looking at the documentation at https://developer.github.com/enterprise/2.19/v4/input_object/addpullrequestreviewcommentinput/ it looks like this parameter is only in the API for github.com and not for GitHub Enterprise.
@shmuelf
Copy link

@shmuelf shmuelf commented Jun 17, 2020

same - on github enterprise
@CodingDinosaur
Copy link

@CodingDinosaur CodingDinosaur commented Jul 1, 2020

Same issue here, GitHub Enterprise 2.17.12, Visual studio 16.6.1.

Also seems like this may be an issue with the GitHub Enterprise API, if it's out of date with the main GitHub API (assuming your GitHub Enterprise version is up to date)? Either way a backwards-compatible implementation seems ideal for VS.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
GitHub Enterprise
  
To do
Milestone
No milestone
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
8 participants
@shmuelf @blkbam @waynebsx @VladRoblox @CodingDinosaur @janecosham @silviofuchs @MilosAuder
You can’t perform that action at this time.