Skip to content

/ lms

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unified logger #139

Merged
merged 10 commits into from Sep 7, 2020
Merged

Unified logger #139

merged 10 commits into from Sep 7, 2020

Conversation

@orronai
Copy link
Collaborator

orronai commented Sep 6, 2020

No description provided.

orronai added 2 commits Aug 25, 2020
@orronai
feat: Ignore files patterns from ignore list
Loading status checks…
fd84a29 
- Create list of patterns that the extractor will ignore
- Fix extractors test and add some test for ignore list
- Fix minor celery issues on local minimized setup
- Remove moment.js request
@orronai
feat: Update structure of ignoring files patterns
Loading status checks…
80d72eb 
- Fix extractors tests
- Fix how to get the ignoring files patterns
@yammesicka

This comment has been minimized.

Sign in to view
Copy link
Member

yammesicka commented on lms/extractors/base.py in 80d72eb Aug 25, 2020 •
edited

Return as a List, or even better, consume it in ziparchive.py.
Currently, if multiple lines try to use UNWANTED_FILE_TYPES, only one of them will be able to use the yielded values.
@yammesicka

This comment has been minimized.

Sign in to view
Copy link
Member

yammesicka commented on lms/extractors/ziparchive.py in 80d72eb Aug 25, 2020

Maybe UNWATED_FILENAMES?
@yammesicka

This comment has been minimized.

Sign in to view
Copy link
Member

yammesicka commented on lms/tests/samples/upload-1-2.ipynb in 80d72eb Aug 25, 2020

This was intentionally there. Please add it as a rule under the .flake8 file
@yammesicka

This comment has been minimized.

Sign in to view
Copy link
Member

yammesicka commented on lms/tests/test_extractor.py in 80d72eb Aug 25, 2020

hmph, this is rather breakable. Let's use try/except instead
@yammesicka

This comment has been minimized.

Sign in to view
Copy link
Member

yammesicka commented on lms/tests/test_extractor.py in 80d72eb Aug 25, 2020

It can be great to assert that there is file named __pycache__/something.py, and to assert it is not exists after we've used the Extractor on it.
orronai added 5 commits Aug 26, 2020
@orronai
feat: Ignore files patterns from ignore list
Loading status checks…
1e94602 
- Fix some extractors tests
- Fix some issues in .flake8
@orronai
feat: Create a unified logger under the `utils` directory
Loading status checks…
aaafef6 
- Fix all the loggers to be one unified
- Fix the loggers to write to a log file
@orronai
feat: Create a unified logger under the `utils` directory
d4a6286 
- Fix the loggers to be one unified
- Fix the loggers to write to a log file
@orronai
Merge branch 'master' into unified-logger
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
54ba269
@orronai
Update loggermanager.py
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
cd4c811 
add rotation every month
@yammesicka
yammesicka requested changes Sep 7, 2020
View changes
lms/extractors/base.py Outdated Show resolved Hide resolved
orronai added 3 commits Sep 7, 2020
@orronai
feat: Create a unified logger under the `utils` directory
f178e2d 
- Fix the logger to be a global unified one
@orronai
Merge branch 'unified-logger' of https://github.com/PythonFreeCourse/lms
Loading status checks…
203ac5b 
 into unified-logger
@orronai
feat: Create a unified logger under the `utils` directory
Loading status checks…
b5e78b4 
- Fix the logger to be one unified
@yammesicka
yammesicka approved these changes Sep 7, 2020
View changes
@orronai orronai merged commit 6b8019c into master Sep 7, 2020
3 checks passed
3 checks passed
build
Details
LGTM analysis: JavaScript No code changes detected
Details
LGTM analysis: Python No new or fixed alerts
Details
@yammesicka yammesicka mentioned this pull request Sep 14, 2020
Closed
@yammesicka yammesicka deleted the unified-logger branch Sep 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yammesicka yammesicka

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
@orronai @yammesicka
You can’t perform that action at this time.