Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upbuild: update buildifier and fix failures #18997
Merged
+561
−580
Conversation
Our version of `@bazel/buildifier` is pretty old. These changes bump to the latest version and fix the new failures that showed up.
crisbeto
requested review from
andrewseguin,
devversion,
jelbourn,
mmalerba and
angular/dev-infra-components
as
code owners
mmalerba
merged commit 8c3ba38
into
angular:master
14 checks passed
14 checks passed
ci/angular: merge status
All checks passed!
cla/google
All necessary CLAs are signed
mmalerba
added a commit
that referenced
this pull request
Apr 14, 2020
Our version of `@bazel/buildifier` is pretty old. These changes bump to the latest version and fix the new failures that showed up.
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Our version of
@bazel/buildifieris pretty old. These changes bump to the latest version and fix the new failures that showed up.