Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upPull Request status circle #2145
Conversation
|
I'd love to see some indication of whether the pull request is in a merge-able state. At the moment we know that Where we see a doughnut ( Crazy idea, could we color the center of the doughnut green or red, when we know the pull request is definitely merge-able or not merge-able? |
|
I pushed a small tweak adjusting the thickness of the donut chart so that it's closer to the line thickness of the octicons: This looks good to be merged in.
@jcansdale I'm hesitant on adding more information since we'll need to come up with an approach that's clear and can fit in the limited amount of space that we have. I struggled with this a bit with the annotation markers; and in the spirit of moving this pull request forward, I think it's best better to punt at this time. Would you be open to showing this type of information in the pull request detail view / sidebar? That way, we can breakdown why a branch isn't mergeable (out of date, review needed, required checks, etc) and guide developers to fix it: |
|
Looks great in general. Just a problem with how you're doing dependency properties. |


My attempt to emulate this in Xaml
TODO:
Remove the summary checks from the View Model, if we decide not to use itIMAGE:
