Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix for decodeDataUrl when data contains newlines #983

Open
wants to merge 1 commit into
base: master
from

Conversation

@damiengrandi
Copy link

@damiengrandi damiengrandi commented Nov 6, 2019

Remove the newlines before doing a Regex check inside the decodeDataUrl method in the same way that is the isBase64 method doing.

Some base64 encoded images contains newlines, passing them directly to the Image::make method can result in a NotReadableException.

Here are the tests I did before this commit :

  • data part only => OK
  • data:[..] header + data part => OK
  • data part only with newlines => OK
  • data:[..] header + data part with newlines => Failure
Remove the newlines before doing a Regex check inside the decodeDataUrl method in the same way that is the isBase64 method doing.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

1 participant
You can’t perform that action at this time.