Bump minimum to PHP 7.3 (as the rest is EOL) #1982

the-djmaze · 2020-03-16T14:16:15Z

The changes in this branch converted all function calls in MailSo and RainLoop libraries to be PHP 7.3+ with type hinting.
Due to the massive changes i couldn't test all conversions yet (so it might be still broken and i'm fixing it).
I've also merged the latest changes since 1.4.0 (but password_hash is different due to PHP 7.3+).

It might work in PHP 7.2 (but that is in extended support 30 Nov 2020)

Most conversion is done by using the doc comments @param and @return and the param $b*, $s*, $i* but these seem to be broken while testing.
Like: "$s*" are bool or "@param string" are "@param string|null"
That's why it takes longer and i didn't create pull requests for documentation errors.

The current marked conflicts are only CRLF vs LF (my files don't use CRLF)


        Bugfix: RainLoopFacebookRedirectLoginHelper should extend \Facebook\H…

…elpers\FacebookRedirectLoginHelper


        Classes to PHP 7.3+

pclzip to ZipArchive

@return


        RainLoop and MailSo libraries @param, @return, etc. to PHP7.3+

This also includes: * removal of PHP_VERSION 5.x checks * use $_SERVER['REQUEST_TIME_FLOAT'] instead of APP_START and APP_START_TIME * use admin password_hash Keep in mind i couldn't test/resolve all potential bugs!


        Fix PHP 7.4 Deprecate message


        Merge pull request #1911 and #1894

@return


        Bugfix: @param/@return documentation was incorrect which caused errors


        Bugfix: mail Message invalid return type


        Bugfix: more function return type errors


        Removed function StripSlashesValue() because PHP7 has no magic_quotes…

…_gpc


        Replaced &$o to $o as objects are always references

Added more type hinting


        Added support for PECL xxtea extension


        Some static \NameSpace\Class:: to static::


        Bugfix: xxtea_decrypt undefined $sString


        Removed safe_mode


        Speedup ImapClient partialParseResponseBranch() and partialResponseLi…

…teralCallbackCallable()

FlorianLaunay · 2020-03-26T08:40:10Z

Hi @RainLoop . Do you plan to check this PR ? It will certainly resolve #1979 on PHP 7.4. Thank you @the-djmaze !


        PHP 7.4/8 error


        More type hinting speedups

the-djmaze · 2020-04-03T09:22:59Z

Hi @RainLoop . Do you plan to check this PR ? It will certainly resolve #1979 on PHP 7.4. Thank you @the-djmaze !

Actually those are already solved a250d84

And this one when you use contacts 2bb947d

I also have more changes prepared (like: class \MailSo\Base\Collection extends \ArrayObject) which gives better memory management and speed.
But when these pulls are not approved i will keep them in my fork


        Resolve some incorrect function return types

phsc84 · 2020-07-07T06:50:08Z

@the-djmaze Do you also provide a ZIP-package of your fork?
@RainLoop Would be great to merge this PR into the official repo!


        Use PHP yaml extension else spyc


        Write 'Auth failed' to syslog when auth_logging=on


        Bugfix: RunAdditionalPart() wrong return type


        Updated inputosaurus.js to work with jQuery3

the-djmaze · 2020-07-10T08:06:19Z

@the-djmaze Do you also provide a ZIP-package of your fork?
@RainLoop Would be great to merge this PR into the official repo!

Not at the moment.
Just pull the source of the php73 branch and upload the content of rainloop/v/0.0.0/ into your existing v1.4.0 to test it.

phsc84 · 2020-07-11T19:11:49Z

I have just tried, what you told me. Unfortunately I get the a blank page. The browser log (F12) shows the folllowing error:
www.abc.com/:1 GET https://www.abc.com/apps/mail/rainloop/v/1.14.0/static/js/min/polyfills.min.js?community net::ERR_ABORTED 404


        Merge remote-tracking branch 'upstream/master' into php73

# Conflicts: # rainloop/v/0.0.0/app/libraries/MailSo/Base/Crypt.php # rainloop/v/0.0.0/app/libraries/MailSo/Base/Utils.php # rainloop/v/0.0.0/app/libraries/MailSo/Mail/MailClient.php # rainloop/v/0.0.0/app/libraries/MailSo/Mime/Email.php # rainloop/v/0.0.0/app/libraries/MailSo/Mime/EmailDep.php # rainloop/v/0.0.0/app/libraries/MailSo/Sieve/ManageSieveClient.php # rainloop/v/0.0.0/app/libraries/RainLoop/Config/Application.php # rainloop/v/0.0.0/app/libraries/RainLoop/Service.php # rainloop/v/0.0.0/app/libraries/RainLoop/ServiceActions.php # rainloop/v/0.0.0/include.php


        Upgrade to custom jQuery UI 1.12.1 due to errors with jQuery 3


        Revert broken RainLoop merge for TemplatesLink


        https://github.com//pull/2005/commits/2d634a09ee355522837d72710aca92b…

…d88bd2167

the-djmaze · 2020-07-15T13:12:02Z

I have just tried, what you told me. Unfortunately I get the a blank page. The browser log (F12) shows the folllowing error:
www.abc.com/:1 GET https://www.abc.com/apps/mail/rainloop/v/1.14.0/static/js/min/polyfills.min.js?community net::ERR_ABORTED 404

You are correct!
Because there is no /rainloop/v/1.14.0/static/ you should use that from the original zip.
Else run npm install and gulp on my source.
And don't use my master branch, because that has stripped functionality.


        Bugfix broken jQuery UI


        Merge remote-tracking branch 'upstream/master' into php73

Merge upstream


        Use Spyc.php v0.6.2


        Cleanup PHP namespaces


        dev/Common/Utils.js isNormal(value) is not needed because 'null == un…

…defined', therefore 'null != value' is sufficient


        Bugfix: setcookie() samesite missing

djmaze added 15 commits Mar 13, 2020

Bugfix: RainLoopFacebookRedirectLoginHelper should extend \Facebook\H…

f7ab900

…elpers\FacebookRedirectLoginHelper

Classes to PHP 7.3+

eba6b28

pclzip to ZipArchive

RainLoop and MailSo libraries @param, @return, etc. to PHP7.3+

c89a936

This also includes: * removal of PHP_VERSION 5.x checks * use $_SERVER['REQUEST_TIME_FLOAT'] instead of APP_START and APP_START_TIME * use admin password_hash Keep in mind i couldn't test/resolve all potential bugs!

Fix PHP 7.4 Deprecate message

2849dde

Merge pull request #1911 and #1894

cf6a95d

Bugfix: @param/@return documentation was incorrect which caused errors

ac8fab0

Bugfix: mail Message invalid return type

8d5da92

Bugfix: more function return type errors

5aa2752

Removed function StripSlashesValue() because PHP7 has no magic_quotes…

8ba18c5

…_gpc

Replaced &$o to $o as objects are always references

bb0183c

Added more type hinting

Added support for PECL xxtea extension

2447668

Some static \NameSpace\Class:: to static::

fa0eb2f

Bugfix: xxtea_decrypt undefined $sString

529bc8a

Removed safe_mode

4de71b2

Speedup ImapClient partialParseResponseBranch() and partialResponseLi…

5cdf5b0

…teralCallbackCallable()

djmaze added 2 commits Apr 3, 2020

PHP 7.4/8 error

2bb947d

More type hinting speedups

b33bf9a

FlorianLaunay mentioned this pull request Apr 10, 2020

PHP 7.4: Array and string offset access syntax with curly braces is deprecated #1979

Open

Resolve some incorrect function return types

a993b13

djmaze added 4 commits Jul 7, 2020

Use PHP yaml extension else spyc

cba9746

Write 'Auth failed' to syslog when auth_logging=on

b61b02a

Bugfix: RunAdditionalPart() wrong return type

30774d1

Updated inputosaurus.js to work with jQuery3

51a145a

djmaze added 2 commits Jul 13, 2020

Upgrade to custom jQuery UI 1.12.1 due to errors with jQuery 3

a1257b8

djmaze added 2 commits Jul 15, 2020

Revert broken RainLoop merge for TemplatesLink

ac2217f

https://github.com//pull/2005/commits/2d634a09ee355522837d72710aca92b…

eb68cb6

…d88bd2167

djmaze added 6 commits Jul 16, 2020

Bugfix broken jQuery UI

2a84184

Merge remote-tracking branch 'upstream/master' into php73

4ef78fb

Merge upstream

Use Spyc.php v0.6.2

3cdbf64

Cleanup PHP namespaces

edb6427

dev/Common/Utils.js isNormal(value) is not needed because 'null == un…

90529d6

…defined', therefore 'null != value' is sufficient

Bugfix: setcookie() samesite missing

53fe661

RainLoop / rainloop-webmail

Bump minimum to PHP 7.3 (as the rest is EOL) #1982

Bump minimum to PHP 7.3 (as the rest is EOL) #1982

the-djmaze commented Mar 16, 2020 •

edited

FlorianLaunay commented Mar 26, 2020

the-djmaze commented Apr 3, 2020 •

edited

phsc84 commented Jul 7, 2020

the-djmaze commented Jul 10, 2020 •

edited

phsc84 commented Jul 11, 2020

the-djmaze commented Jul 15, 2020 •

edited

RainLoop / rainloop-webmail

Join GitHub today

Bump minimum to PHP 7.3 (as the rest is EOL) #1982

Bump minimum to PHP 7.3 (as the rest is EOL) #1982

Conversation

the-djmaze commented Mar 16, 2020 • edited

FlorianLaunay commented Mar 26, 2020

the-djmaze commented Apr 3, 2020 • edited

phsc84 commented Jul 7, 2020

the-djmaze commented Jul 10, 2020 • edited

phsc84 commented Jul 11, 2020

the-djmaze commented Jul 15, 2020 • edited

the-djmaze commented Mar 16, 2020 •

edited

the-djmaze commented Apr 3, 2020 •

edited

the-djmaze commented Jul 10, 2020 •

edited

the-djmaze commented Jul 15, 2020 •

edited