Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update copyright notice to latest guidance #12190

Merged
merged 1 commit into from Mar 24, 2020

Conversation

@SteveL-MSFT
Copy link
Member

@SteveL-MSFT SteveL-MSFT commented Mar 23, 2020

PR Summary

Latest guidance is to not have the All rights reserved. sentence.

PR Checklist

Copy link
Member

@TravisEz13 TravisEz13 left a comment

Did rules base review using beyond compare

@TravisEz13 TravisEz13 added this to the 7.1.0-preview.2 milestone Mar 24, 2020
@TravisEz13 TravisEz13 merged commit b7cb335 into PowerShell:master Mar 24, 2020
10 checks passed
10 checks passed
Codacy/PR Quality Review Up to standards. A positive pull request.
Details
CodeFactor 74 issues fixed. 1 issue found.
Details
PowerShell-CI-SSH #PR-12190-20200323.01 succeeded
Details
PowerShell-CI-install-ps #PR-12190-20200323.01 succeeded
Details
PowerShell-CI-linux #PR-12190-20200323.01 succeeded
Details
PowerShell-CI-macos #PR-12190-20200323.01 succeeded
Details
PowerShell-CI-static-analysis #PR-12190-20200323.01 succeeded
Details
PowerShell-CI-windows #PR-12190-20200323.01 succeeded
Details
WIP Ready for review
Details
license/cla All CLA requirements met.
Details
@msftbot
Copy link

@msftbot msftbot bot commented Apr 23, 2020

🎉v7.1.0-preview.2 has been released which incorporates this pull request.🎉

Handy links:

msftbot bot pushed a commit that referenced this pull request May 20, 2020
…ts (#12722)

# PR Summary

<!-- Summarize your PR between here and the checklist. -->

## PR Context

follow-up #12190

## PR Checklist

- [x] [PR has a meaningful title](https://github.com/PowerShell/PowerShell/blob/master/.github/CONTRIBUTING.md#pull-request---submission)
    - Use the present tense and imperative mood when describing your changes
- [x] [Summarized changes](https://github.com/PowerShell/PowerShell/blob/master/.github/CONTRIBUTING.md#pull-request---submission)
- [ ] [Make sure all `.h`, `.cpp`, `.cs`, `.ps1` and `.psm1` files have the correct copyright header](https://github.com/PowerShell/PowerShell/blob/master/.github/CONTRIBUTING.md#pull-request---submission)
- [x] This PR is ready to merge and is not [Work in Progress](https://github.com/PowerShell/PowerShell/blob/master/.github/CONTRIBUTING.md#pull-request---work-in-progress).
    - If the PR is work in progress, please add the prefix `WIP:` or `[ WIP ]` to the beginning of the title (the `WIP` bot will keep its status check at `Pending` while the prefix is present) and remove the prefix when the PR is ready.
- **[Breaking changes](https://github.com/PowerShell/PowerShell/blob/master/.github/CONTRIBUTING.md#making-breaking-changes)**
    - [x] None
    - **OR**
    - [ ] [Experimental feature(s) needed](https://github.com/MicrosoftDocs/PowerShell-Docs/blob/staging/reference/6/Microsoft.PowerShell.Core/About/about_Experimental_Features.md)
        - [ ] Experimental feature name(s): <!-- Experimental feature name(s) here -->
- **User-facing changes**
    - [x] Not Applicable
    - **OR**
    - [ ] [Documentation needed](https://github.com/PowerShell/PowerShell/blob/master/.github/CONTRIBUTING.md#pull-request---submission)
        - [ ] Issue filed: <!-- Number/link of that issue here -->
- **Testing - New and feature**
    - [x] N/A or can only be tested interactively
    - **OR**
    - [ ] [Make sure you've added a new test if existing tests do not effectively test the code changed](https://github.com/PowerShell/PowerShell/blob/master/.github/CONTRIBUTING.md#before-submitting)
- **Tooling**
    - [x] I have considered the user experience from a tooling perspective and don't believe tooling will be impacted.
    - **OR**
    - [ ] I have considered the user experience from a tooling perspective and enumerated concerns in the summary. This may include:
        - Impact on [PowerShell Editor Services](https://github.com/PowerShell/PowerShellEditorServices) which is used in the [PowerShell extension](https://github.com/PowerShell/vscode-powershell) for VSCode (which runs in a different PS Host).
        - Impact on Completions (both in the console and in editors) - one of PowerShell's most powerful features.
        - Impact on [PSScriptAnalyzer](https://github.com/PowerShell/PSScriptAnalyzer) (which provides linting & formatting in the editor extensions).
        - Impact on [EditorSyntax](https://github.com/PowerShell/EditorSyntax) (which provides syntax highlighting with in VSCode, GitHub, and many other editors).
@SteveL-MSFT SteveL-MSFT deleted the SteveL-MSFT:copyright-update branch Jun 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.