pbardea
Follow
Create your own GitHub profile
Sign up for your own profile on GitHub, the best place to host code, manage projects, and build software alongside 50 million developers.
Sign up
Pinned
1,484 contributions in the last year
Activity overview
Contributed to
cockroachdb/cockroach,
cockroachdb/cockroach-gen,
cockroachlabs/release-staging
and 5 other
repositories
Contribution activity
September 2020
Created a pull request in cockroachdb/cockroach that received 6 comments
backupccl: check privileges on types and schemas during backup
This commit adds a check that ensures that the user running the backup has USAGE privileges on the schemas and types they're backing up. Note that …
+7
−1
•
6
comments
- backupccl: add more backup telemetry
- backupccl: fix auto-append destination resolution
- backupccl: unskip TestBackupRestoreAppend
- release-20.2: backupccl: check privileges on types and schemas during backup
- release-20.1: backupccl: show schema privileges in SHOW BACKUP
- release-20.2: backupccl: update RestoreDataProcessor to use ProcessorBase
- backupccl: clear table stats from manifest on canceled backup
- backupccl: disallow incrementals with new complete databases
- backupccl: fix descriptor privilege restoration
- release-20.2: backupccl: fix NPE during restore rollback
- [dnm] Using CI
- backupccl: show schema privileges in SHOW BACKUP
- schemafeed: fix race when peeking events from schema feed
- release-20.1: backupccl: add logging when descriptor fails validation
- release-20.1: backupccl: clear table stats from manifest on canceled backup
- backupccl: enum/schemas integration with privileges in BACKUP/RESTORE
- importccl: unskip most tests in TestImportData
- cloudimpl: handle retires in usefile writes
- backupccl: fix NPE during restore rollback
- backupccl: update RestoreDataProcessor to use ProcessorBase
- backupccl: remove targets from restore resumer
- release-20.1: backupccl: fix database resolution for revision_history cluster backups
- backupccl: name which descriptors are blocking cluster restore
- backupccl: rename backup manifest file
- roachtest: update jobs/mixed-version to use RESTORE
- userfile: add userfile telemetry
- bulkio: Propagate errors when executing schedule.
- backupccl: redact storage URIs printed in error messages during BACKUP
- backupccl: disallow incrementals with new complete databases
- release-20.2: backupccl,importccl: only reset ModificationTime on tables after upgrade
- changefeedccl/schemafeed: only sort the unsorted tail of descriptors
- release-20.1: gcjobnotifier: unify gcjobs around a single copy of the system config
- backupccl,importccl: only reset ModificationTime on tables after upgrade
- backfill: add memory accounting to the column/index backfiller
- release-20.2: gcjobnotifier: unify gcjobs around a single copy of the system config
- sql/catalog, backupccl: support offline descriptors, add all new restored descriptors in offline state
- gcjobnotifier: unify gcjobs around a single copy of the system config
- backupccl: fix glob used when finding prior BACKUP subdirs
- build: remove old release scripts
- filetable: allow overwrite during BACKUP and fix delete bug
- cloudimpl: handle retires in usefile writes
- sql,tree: move descriptor-specific flags to CommonLookupFlags
- sql,catalog/descs,gcjob,lease,importccl,backupccl: replace PublishMultiple
- backupccl: update RestoreDataProcessor to use ProcessorBase
- sql,importccl: adopt jobs.TestingSetAdoptAndCancelIntervals
- backupccl: fix TestClientDisconnect/RESTORE
- roachtest: update jobs/mixed-version to use RESTORE
- backupccl: fix restore AOST timestamp error printing
- importccl: partially unskip TestImportData
- bulkio: Fix backup tpcc roachtest failure.
- Some pull request reviews not shown.
Created an issue in cockroachdb/cockroach that received 4 comments
sql: panic on hydrating dropped types
Describe the problem CockroachDB hits an NPE when trying to fetch all descriptors after dropping a database with a type and a table referencing it.…
4
comments
- bulkio: add backup/restore mode to logic tests
- import: PGDUMP imports do not suport ALTER SEQUENCE ... OWNED BY ...
- import: CSV import does not work with collated strings
- import: duplicate primary index allowed for collated strings
- backup: appendable backups do not work with userfile destinations
- restore: RESTORE flow hangs when `RestoreDataProcessor` quickly throws an error
- jobs: expose jobs adoption and cancel intervals through a cluster setting
- backupccl: RESTORE may fail if run during a cluster upgrade