Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upContact type is confusing #84
Open
Comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The contact type in
PositionBasedDynamics/Simulation/CollisionDetection.h
Line 14 in b142aad
is not useful at all and should be deleted, although it's not really used in the code.
I assume that
PositionBasedDynamics/Simulation/DistanceFieldCollisionDetection.h
Line 108 in b142aad
Thus, I think it should be corrected as follows:
To be clear when reading the source code, I think it's better to use static value when creating
contacts_mtand contact constraints invoid DistanceFieldCollisionDetection::collisionDetection(SimulationModel &model)such asPositionBasedDynamics/Simulation/DistanceFieldCollisionDetection.cpp
Line 163 in b142aad