Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move functions from psa_crypto_helpers.h to a .c file #3606

Open
gilles-peskine-arm opened this issue Aug 25, 2020 · 0 comments
Open

Move functions from psa_crypto_helpers.h to a .c file #3606

gilles-peskine-arm opened this issue Aug 25, 2020 · 0 comments

Comments

@gilles-peskine-arm
Copy link
Contributor

@gilles-peskine-arm gilles-peskine-arm commented Aug 25, 2020

tests/include/test/psa_crypto_helpers.h contains function definitions. That's a remnant from when we didn't have tests/src/*.c and unit tests had to be compiled as a monolithic C file. It's a problem because merely including the header causes an unused-function warning. The header should contain only function declarations (or static inline function definitions, but the functions in that header don't need to be inline).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
1 participant
You can’t perform that action at this time.