Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upGitHub is where the world builds software
Millions of developers and companies build, ship, and maintain their software on GitHub — the largest and most advanced development platform in the world.
Issue with a Communicator.EventHandler.receivedMessage(Object input) logger #93
Comments
|
Hi @artado, Thanks for your input. My guess is, that there isn't any ToString() on the CallMessage class. It would be a good idea to implement one. In unrelated news, I see there is a lower level check on the data type, and then a downcast. I'll mark it in my black book of technical debt. :) |
|
@TVolden or we create a separate issue as 'good first issue' for the data type check? |
|
Good idea @dersteve I'm thinking we could solve it using a double dispatch method, like visitor pattern. |
Hello,
I believe there is an issue with a Communicator.EventHandler.receivedMessage(Object input) when it tries to logger.trace("Receive a message: {}", message) for a JSON message.
What I`m getting in a log console is:
While in a Wireshark I can see:
Could it be something to do with a missing .toString() method for a Message class?
The text was updated successfully, but these errors were encountered: