Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setup CI infra to run DevTools tests against multiple React versions #19371

Open
bvaughn opened this issue Jul 15, 2020 · 0 comments
Open

Setup CI infra to run DevTools tests against multiple React versions #19371

bvaughn opened this issue Jul 15, 2020 · 0 comments

Comments

@bvaughn
Copy link
Contributor

@bvaughn bvaughn commented Jul 15, 2020

PR #19108 caused some Suspense-related DevTools regressions (more info available on #19368) which we did not catch because of the fact that DevTools tests are only run against the version of React in master.

We should follow the precedent of the regression fixtures tests and have CI run DevTools tests against multiple React versions, including v15, all v16 minors, and the current HEAD of master branch.

Setting this up will involve several things:

  • Infra to checkout older React packages and run tests against them.
  • Some form of gating so that we can account for expected differences in Store snapshots between React versions.
  • Some form of gating so that we can avoid running tests against invalid combinations of features and versions (e.g. don't test for Suspense in a version of React that didn't include that component yet).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.