Skip to content

/ zipkin-js

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

http tests should cover the client originated trace use case #346

Open
adriancole opened this issue Mar 26, 2019 · 2 comments
Open

http tests should cover the client originated trace use case #346

adriancole opened this issue Mar 26, 2019 · 2 comments
Labels
good first issue help wanted techdebt
Milestone
1.0

Comments

@adriancole
Copy link
Contributor

@adriancole adriancole commented Mar 26, 2019

@thegryfon noticed that in community axios implementations, some leak contexts and you wouldn't necessarily know until a second root trace is attempted.

here's an example scenario I think tests could cover:

there is no parent trace in scope
create a client request
create a second client request
verify that both client requests are root spans
@jcchavezs jcchavezs added this to the 1.0 milestone Mar 26, 2019
@thegryfon
Copy link

@thegryfon thegryfon commented Jun 18, 2019

@adriancole continuing our last discussion, how can i help
@adriancole
Copy link
Contributor Author

@adriancole adriancole commented Jun 18, 2019

suppose this was a request to backfill tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue help wanted techdebt
Projects
None yet
Milestone
1.0
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants
@adriancole @jcchavezs @thegryfon
You can’t perform that action at this time.