Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upAdded words relating to adopting semantics of JSON Schema #2330
Conversation
|
Tiny nits, otherwise LGTM. |
|
|
||
| For more information about the properties, see [JSON Schema Core](https://json-schema.org/draft/2019-09/json-schema-core.html) and [JSON Schema Validation](https://json-schema.org/draft/2019-09/json-schema-validation.html). | ||
|
|
||
| Unless stated otherwise, the property definitions follow the JSON Schema. | ||
| Unless stated otherwise, the property definitions follow the JSON Schema and does not add any additional semantics. |
This comment has been minimized.
This comment has been minimized.
MikeRalphson
Aug 29, 2020
•
Member
Suggested change
| Unless stated otherwise, the property definitions follow the JSON Schema and does not add any additional semantics. | |
| Unless stated otherwise, the property definitions follow those of JSON Schema and do not add any additional semantics. |
|
|
||
| For more information about the properties, see [JSON Schema Core](https://json-schema.org/draft/2019-09/json-schema-core.html) and [JSON Schema Validation](https://json-schema.org/draft/2019-09/json-schema-validation.html). | ||
|
|
||
| Unless stated otherwise, the property definitions follow the JSON Schema. | ||
| Unless stated otherwise, the property definitions follow the JSON Schema and does not add any additional semantics. | ||
| Where JSON Schema indicates that behavior is defined by the application (e.g. for annotations), OAS also defers the definition of semantics to the application consuming the OpenAPI description. |
This comment has been minimized.
This comment has been minimized.
MikeRalphson
Aug 29, 2020
Member
Suggested change
| Where JSON Schema indicates that behavior is defined by the application (e.g. for annotations), OAS also defers the definition of semantics to the application consuming the OpenAPI description. | |
| Where JSON Schema indicates that behavior is defined by the application (e.g. for annotations), OAS also defers the definition of semantics to the application consuming the OpenAPI document. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
darrelmiller commentedAug 28, 2020
•
edited
Addresses #2326