Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

username provide to the git commiter should be first name + lastname #15419

Open
sunix opened this issue Dec 6, 2019 · 2 comments
Open

username provide to the git commiter should be first name + lastname #15419

sunix opened this issue Dec 6, 2019 · 2 comments
Labels
area/git dogfooding good first issue kind/bug lifecycle/frozen severity/P2 team/plugins

Comments

@sunix
Copy link
Contributor

@sunix sunix commented Dec 6, 2019

Describe the bug

#14416 provides a nice feature: the Che user don't have to fill his name and email to perform a git commit: all is already injected with the default information that the user have generally provided when creating its user profile.
The problem is, name use is the username, not the first name + the last name. Which is not very nice when username is not meaning full. For instance, in some environment, my username is user1.

when executing git log:

commit 8e804b49c7313a036d4c973f4718b618dad6b5d8
Author: user1 <sutan@redhat.com>
Date:   Thu Dec 5 15:24:50 2019 +0000

    removing unused yarn.lock that also contain security warning

commit 4ed171b13f05df5417ec9995ff0295ff1145633f
Author: user1 <sutan@redhat.com>
Date:   Thu Dec 5 15:08:43 2019 +0000

    adding missing env file (was in .gitignore ...)

commit afba9a437aac4cc83fc72508abd70ef9a9c44bd0
Author: user1 <sutan@redhat.com>
Date:   Thu Dec 5 14:57:05 2019 +0000

    Reenable react devmode by using proxy feature
@sunix sunix added kind/bug team/plugins area/editor/che-theia labels Dec 6, 2019
@che-bot che-bot added the status/need-triage label Dec 6, 2019
@tolusha tolusha added severity/P2 and removed status/need-triage labels Dec 8, 2019
@sunix sunix added good first issue area/git labels Mar 29, 2020
@benoitf benoitf added dogfooding area/che-server and removed area/editor/che-theia labels Jul 30, 2020
@che-bot
Copy link
Contributor

@che-bot che-bot commented Feb 4, 2021

Issues go stale after 180 days of inactivity. lifecycle/stale issues rot after an additional 7 days of inactivity and eventually close.

Mark the issue as fresh with /remove-lifecycle stale in a new comment.

If this issue is safe to close now please do so.

Moderators: Add lifecycle/frozen label to avoid stale mode.

@che-bot che-bot added the lifecycle/stale label Feb 4, 2021
@ericwill ericwill added lifecycle/frozen and removed lifecycle/stale labels Feb 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/git dogfooding good first issue kind/bug lifecycle/frozen severity/P2 team/plugins
Projects
None yet
Development

No branches or pull requests

6 participants