Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added configuration options for ForwardedHeaders #394

Open
wants to merge 2 commits into
base: master
from

Conversation

@theSuess
Copy link

@theSuess theSuess commented Nov 13, 2018

This allows for the use of load balancers not connected via localhost

@kspearrin
Copy link
Collaborator

@kspearrin kspearrin commented Nov 13, 2018

There are many other projects as well: Identity, Icons, Notifications, etc. Do these all need these options too?

@theSuess
Copy link
Author

@theSuess theSuess commented Nov 13, 2018

These projects don't need the client IP. API and Admin use the IP for access logging

@kspearrin
Copy link
Collaborator

@kspearrin kspearrin commented Nov 13, 2018

Ok. Can you explain what type of setup you have here that is requiring these headers vs a regular installation?

@theSuess
Copy link
Author

@theSuess theSuess commented Nov 13, 2018

Our BitWarden setup is running on OpenShift. With this setup, each project has a different IP. When nginx is passing the X-Forwarded-For headers upstream, the API does not use this information as the nginx ip is not in its list of KnownProxies or KnownNetworks

@kspearrin
Copy link
Collaborator

@kspearrin kspearrin commented Nov 13, 2018

each project has a different IP

Do you mean each Bitwarden project (API, Admin, etc) or something else?

@theSuess
Copy link
Author

@theSuess theSuess commented Nov 13, 2018

yes, that's the issue

@kspearrin
Copy link
Collaborator

@kspearrin kspearrin commented Nov 13, 2018

If Admin and API have different proxy IP addresses then this solution would not work. You have it specified in global settings, which there is only one of (defined in global env file) that will apply to all containers.

@theSuess
Copy link
Author

@theSuess theSuess commented Nov 13, 2018

Admin and API get served by the same proxy but they reject the headers

@CLAassistant
Copy link

@CLAassistant CLAassistant commented Mar 7, 2020

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.