Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

`cargo crev change passphrase` #152

Open
dpc opened this issue Jan 11, 2019 · 4 comments
Open

`cargo crev change passphrase` #152

dpc opened this issue Jan 11, 2019 · 4 comments

Comments

@dpc
Copy link
Collaborator

@dpc dpc commented Jan 11, 2019

Especially in the light of #151 , it would be great if people could just re-generate the whole Id file.

@zicklag
Copy link

@zicklag zicklag commented Apr 4, 2020

This might ( no promises ) be something I could find time for. Could you assign this to me to help me not to forget?

Also if you have any quick pointers on what needs to happen that would be cool, too. 🙂

@dpc
Copy link
Collaborator Author

@dpc dpc commented Apr 4, 2020

Awesome.

Every id belonging to the user (OwnId) is stored "locked" on disk, with its secret key encrypted (sealed) with user provieded passphrase.

Changing a passphrase should be as simple as unlocking it, asking for a new passphrase, and locking it again, just like when it was created.

@zicklag
Copy link

@zicklag zicklag commented Apr 4, 2020

Oh, sweet. That sounds like a piece of 🍰 then. 😃

@dpc
Copy link
Collaborator Author

@dpc dpc commented Apr 4, 2020

BTW. Saving the id should use safe overwritting: write tmpfile, flush, sync, rename, sync, to make it impossible to corrupt the file on crash and loose the identity. There's even a common function for that but since we never before overwrote it, I never got to change it to use it.

Oh, and user should be prompted to make a new backup, since the old backup will still use old passphrase, which the user might soon forget.

And yeah, this 🤞 shouldn't be too much work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.