Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.
Sign upproposal: `node inspect` CLI debugger #42
Conversation
jkrems
force-pushed the
jkrems:jk-node-inspect
branch
from
2ea0398
to
cb546c2
Sep 4, 2016
This comment has been minimized.
This comment has been minimized.
|
I published the "polyfill" to npm as npm install --global node-inspectFor the implementation status, see this tracking issue. Most things should work already. |
This comment has been minimized.
This comment has been minimized.
|
This is definitely interesting but I'm wondering if it would be better to develop this as a standalone client for the time being. Once it's functional, then we can look to see how much sense it makes to bringing it in to core. |
This comment has been minimized.
This comment has been minimized.
|
That definitely makes sense. And I'm not looking to submit the code I linked to above to core in the next few days or immediately after this proposal is finalized/merged. But my impression was that the current command line debugger is already depending on (more or less) unsupported parts of V8. So it seemed like a good idea to have an official plan for "the day it breaks". The proposal explicitly doesn't mention my repo. It just suggests a potential interface for transitioning the official built-in debugger from the old V8 protocol to the new inspector protocol. |
This comment has been minimized.
This comment has been minimized.
|
btw, relevant to this: nodejs/node#7266 |
This comment has been minimized.
This comment has been minimized.
|
Thanks for the link! Must've been blind. :) |
This comment has been minimized.
This comment has been minimized.
|
After playing around with the finished debugger - it feels like a wasted opportunity to go down this route. |
jkrems commentedSep 4, 2016
•
edited
I think this came up during the original V8 inspector discussions.
P.S.: I created a POC port of
lib/_debugger.jsto the--inspectprotocol to make sure this could reasonably be done in core without pulling in additional dependencies.