Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(mdc-chips): add performance tests for mdc-chips #20131

Merged
merged 6 commits into from Aug 6, 2020

Conversation

wagnermaciel
Copy link
Contributor

@wagnermaciel wagnermaciel commented Jul 29, 2020

Context

This branch is checked out of #20032 because it needs the changes to material-experimental's indigo-pink theme.

@wagnermaciel wagnermaciel requested review from mmalerba and as code owners Jul 29, 2020
@googlebot googlebot added the cla: yes label Jul 29, 2020
<mat-chip *ngIf="isSingleVisible">One</mat-chip>
<mat-chip-set *ngIf="isMultipleVisible">
Copy link
Member

@crisbeto crisbeto Jul 30, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aside from mat-chip-set, we also have a mat-chip-grid and mat-chip-listbox that should probably cover. Furthermore, there are other components like the chip avatar and remove button that aren't represented here.

Copy link
Contributor Author

@wagnermaciel wagnermaciel Jul 30, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done. I am a bit confused with mat-chip-grid and perhaps you could help me out here. If I do not provide an input within the mat-chip-grid alongside the mat-chip-rows the rows do not work properly. Am I doing something wrong or is this intentional?

Here is a link to the html for this

test/benchmarks/mdc/chips/app.module.ts Outdated Show resolved Hide resolved
Copy link
Contributor

@mmalerba mmalerba left a comment

LGTM

@devversion devversion added blocked merge ready target: patch labels Aug 3, 2020
@wagnermaciel wagnermaciel removed the blocked label Aug 5, 2020
@wagnermaciel wagnermaciel added the merge safe label Aug 5, 2020
@mmalerba mmalerba merged commit cd433a4 into angular:master Aug 6, 2020
15 checks passed
mmalerba pushed a commit that referenced this issue Aug 6, 2020
* fix(mdc-indigo-pink): add mat-core and mat-core-theme to indigo-pink

* fixup! fix(mdc-indigo-pink): add mat-core and mat-core-theme to indigo-pink

* test(mdc-chips): add performance tests for mdc-chips

* fix(mdc-chips-benchmark): remove unnecessary providers

* fix(mdc-chips-benchmark): add tests for grid and listbox

* fixup! fix(mdc-chips-benchmark): add tests for grid and listbox

(cherry picked from commit cd433a4)
@angular-automatic-lock-bot
Copy link

@angular-automatic-lock-bot angular-automatic-lock-bot bot commented Sep 6, 2020

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 6, 2020
@wagnermaciel wagnermaciel deleted the mdc-chips-benchmark branch Jan 14, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla: yes merge ready merge safe target: patch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants