src: large pages support for illumos/solaris systems. #34320
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
build
jasnell
approved these changes
Jul 12, 2020
|
ping @gabrielschulhof :-) |
lundibundi
reviewed
Aug 24, 2020
|
ping @gabrielschulhof @addaleax based on recent changes to those files. |
fhinkel
approved these changes
Aug 24, 2020
github-actions
bot
removed
the
request-ci
devnexen
force-pushed
the
illumos_large_pages
branch
2 times, most recently
from
c168c24
to
6c11263
Compare
|
ping @devnexen could you please clarify questions in my review and I guess this is ready to land after that? Also, is there no solaris on our CI? |
|
sorry for having dismissed your primary question... |
* Making sure using apis supported by both.
The closest we have in the CI is SmartOS. |
|
@devnexen no problem Then I guess we just have to format this with clang-format and this can land. |
github-actions
bot
removed
the
request-ci
lundibundi
approved these changes
Sep 3, 2020
github-actions
bot
removed
the
request-ci
gabrielschulhof
added
the
author ready
devnexen
added a commit
that referenced
this issue
Oct 19, 2020
Making sure using apis supported by both.
PR-URL: #34320
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Gabriel Schulhof <gabriel.schulhof@intel.com>
Reviewed-By: Denys Otrishko <shishugi@gmail.com>
|
Landed on 2b3acc4. |
BethGriggs
added a commit
that referenced
this issue
Dec 8, 2020
Making sure using apis supported by both.
PR-URL: #34320
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Gabriel Schulhof <gabriel.schulhof@intel.com>
Reviewed-By: Denys Otrishko <shishugi@gmail.com>
BethGriggs
added a commit
that referenced
this issue
Dec 10, 2020
Making sure using apis supported by both.
PR-URL: #34320
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Gabriel Schulhof <gabriel.schulhof@intel.com>
Reviewed-By: Denys Otrishko <shishugi@gmail.com>
Merged
BethGriggs
added a commit
that referenced
this issue
Dec 15, 2020
Making sure using apis supported by both.
PR-URL: #34320
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Gabriel Schulhof <gabriel.schulhof@intel.com>
Reviewed-By: Denys Otrishko <shishugi@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes