Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(drag-drop): warn if connected container ID doesn't exist #20057

Merged
merged 1 commit into from Jul 24, 2020

Conversation

crisbeto
Copy link
Member

@crisbeto crisbeto commented Jul 21, 2020

We support connecting two drop lists by their ID, but if the ID is incorrect, we silently ignore it. These changes add a warning so it's easier to debug issues where the ID might be misspelled.

Fixes #20056.

We support connecting two drop lists by their ID, but if the ID is incorrect, we silently ignore it. These changes add a warning so it's easier to debug issues where the ID might be misspelled.

Fixes angular#20056.
@crisbeto crisbeto force-pushed the 20056/drag-drop-id-warning branch from b9a526f to 3b70de9 Compare Jul 21, 2020
Copy link
Member

@jelbourn jelbourn left a comment

LGTM

@wagnermaciel wagnermaciel merged commit 89b5fa8 into angular:master Jul 24, 2020
15 checks passed
wagnermaciel added a commit that referenced this issue Jul 24, 2020
We support connecting two drop lists by their ID, but if the ID is incorrect, we silently ignore it. These changes add a warning so it's easier to debug issues where the ID might be misspelled.

Fixes #20056.

(cherry picked from commit 89b5fa8)
@angular-automatic-lock-bot
Copy link

@angular-automatic-lock-bot angular-automatic-lock-bot bot commented Aug 24, 2020

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Aug 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

4 participants