Skip to content

/ actions

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

maintain one single top-level node_modules #22

Merged
merged 1 commit into from Jul 5, 2020
Merged

maintain one single top-level node_modules #22

merged 1 commit into from Jul 5, 2020

Conversation

@dawidd6
Copy link
Member

dawidd6 commented Jul 4, 2020

node searches parent directory for node_modules too, so we can deduplicate some code and maintain one single node_modules directory with dependencies.
@dawidd6
maintain one single top-level node_modules
Verified
This commit was signed with a verified signature.
dawidd6 Dawid Dziurla
GPG key ID: 7B6D8368172E9B0B Learn about signing commits
Loading status checks…
07da079
@dawidd6 dawidd6 force-pushed the node_modules branch from c3039df to 07da079 Jul 4, 2020
@MikeMcQuaid
MikeMcQuaid approved these changes Jul 4, 2020
View changes
@dawidd6 dawidd6 marked this pull request as ready for review Jul 4, 2020
@dawidd6
Copy link
Member Author

dawidd6 commented Jul 5, 2020

Merging now, will make a follow-up PR with docs.
@dawidd6 dawidd6 merged commit 1579bd1 into master Jul 5, 2020
8 checks passed
8 checks passed
script
Details
cancel
Details
dismiss-approvals
Details
download
Details
upload
Details
try-push
Details
user-config
Details
post-comment
Details
@dawidd6 dawidd6 deleted the node_modules branch Jul 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MikeMcQuaid MikeMcQuaid

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
@dawidd6 @MikeMcQuaid
You can’t perform that action at this time.