Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add icon and add reference in readme and manifest #1291

Merged
merged 4 commits into from Aug 27, 2019

Conversation

@bergmeister
Copy link
Collaborator

bergmeister commented Jul 13, 2019

PR Summary

@adilio was kind enough to create a logo. This adds it to the main readme so that it is visible when browsing it to the repo and the module manifest so that it appears on the PSGallery.
The logo was taken from his repo, which is under MIT:
https://github.com/adilio/ps-design/tree/master/psscriptanalyzer
I have tested that the icon gets displayed correctly by uploading this test module: https://www.poshtestgallery.com/packages/foo/0.0.5

PR Checklist

bergmeister added 2 commits Jul 13, 2019
@adilio
Copy link

adilio commented Jul 13, 2019

Hey @bergmeister, the icon in the test PSGallery is.... umm.... triggering my OCD 😅.

If you'd like to get the dimensions required, I can create a properly-scaled file for you?

Also, just thought I'd pass on that, when placing an img HTML tag referencing images, I find it's easier to just define one dimension. That way, the other dimension is automatically calculated to be the correct ratio, and you don't have to worry about pixelation from slight differences.

Just my 2 pesos 🙂.

@bergmeister
Copy link
Collaborator Author

bergmeister commented Jul 13, 2019

Thanks for the tip with the img tag, that makes it easier.
I am not sure what the requirements are for the PSGallery but to me it seems that they resize the image to be square. Do you have a preference on being acknowledged in a certain way (e.g. to have a Readme in the assets folder to point to your original source)

@adilio
Copy link

adilio commented Jul 13, 2019

Understood. I have just pushed two new versions to the repo. Both have a square base image size, so it won't skew images at all. One is original size, one is at 300px.

https://github.com/adilio/ps-design/blob/master/psscriptanalyzer/pssa-logo-square.png
https://github.com/adilio/ps-design/blob/master/psscriptanalyzer/pssa-logo-square-300.png

@bergmeister
Copy link
Collaborator Author

bergmeister commented Jul 21, 2019

Thanks @adilio
I updated the logo in the published test module and in this PR to use the new square logo. This is how it'd look like now:
https://www.poshtestgallery.com/packages/foo/0.0.5

@bergmeister bergmeister marked this pull request as ready for review Aug 18, 2019
@JamesWTruher JamesWTruher merged commit a449c2c into PowerShell:master Aug 27, 2019
1 of 2 checks passed
1 of 2 checks passed
continuous-integration/appveyor/pr AppVeyor build failed
Details
license/cla All CLA requirements met.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.