Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upAdd icon and add reference in readme and manifest #1291
Conversation
adilio
commented
Jul 13, 2019
|
Hey @bergmeister, the icon in the test PSGallery is.... umm.... triggering my OCD If you'd like to get the dimensions required, I can create a properly-scaled file for you? Also, just thought I'd pass on that, when placing an Just my 2 pesos |
|
Thanks for the tip with the |
adilio
commented
Jul 13, 2019
|
Understood. I have just pushed two new versions to the repo. Both have a square base image size, so it won't skew images at all. One is original size, one is at 300px. https://github.com/adilio/ps-design/blob/master/psscriptanalyzer/pssa-logo-square.png |
|
Thanks @adilio |
bergmeister commentedJul 13, 2019
•
edited
PR Summary
@adilio was kind enough to create a logo. This adds it to the main readme so that it is visible when browsing it to the repo and the module manifest so that it appears on the PSGallery.
The logo was taken from his repo, which is under MIT:
https://github.com/adilio/ps-design/tree/master/psscriptanalyzer
I have tested that the icon gets displayed correctly by uploading this test module: https://www.poshtestgallery.com/packages/foo/0.0.5
PR Checklist
.cs,.ps1and.psm1files have the correct copyright headerWIP:to the beginning of the title and remove the prefix when the PR is ready.