Skip to content

/ ndarray

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add code coverage #641

Closed
wants to merge 12 commits into from
Closed

Add code coverage #641

wants to merge 12 commits into from

Conversation

@max-sixty
Copy link
Contributor

@max-sixty max-sixty commented Jun 11, 2019

From https://github.com/xd009642/tarpaulin#travis-ci-and-coverage-sites

Closes #618
max-sixty added 5 commits Jun 11, 2019
@max-sixty
Add code coverage
Verified
This commit was signed with a verified signature.
max-sixty Maximilian Roos
GPG key ID: 3232F28BEDA66FCD Learn about signing commits
Loading status checks…
81ddeb5
@max-sixty
bashful
Verified
This commit was signed with a verified signature.
max-sixty Maximilian Roos
GPG key ID: 3232F28BEDA66FCD Learn about signing commits
Loading status checks…
4d05b2e
@max-sixty
move cargo install into before_script
Verified
This commit was signed with a verified signature.
max-sixty Maximilian Roos
GPG key ID: 3232F28BEDA66FCD Learn about signing commits
Loading status checks…
318d9d6
@max-sixty
only install tarpaulin if rustc >= 1.32
Verified
This commit was signed with a verified signature.
max-sixty Maximilian Roos
GPG key ID: 3232F28BEDA66FCD Learn about signing commits
Loading status checks…
4f45930
@max-sixty
ok bash
Verified
This commit was signed with a verified signature.
max-sixty Maximilian Roos
GPG key ID: 3232F28BEDA66FCD Learn about signing commits
Loading status checks…
3023230
@max-sixty
Copy link
Contributor Author

@max-sixty max-sixty commented Jun 12, 2019

Tests are passing now. Let me know any feedback.

IIUC someone with repo access will need to enable for coveralls in order to see & record the results
@LukeMathWalker
Copy link
Member

@LukeMathWalker LukeMathWalker commented Jun 13, 2019

Nice!
@jturner314, you enabled codecov for ndarray-stats - should we use the same account for all crates in this organization? Not familiar with the tool 🙌
@termoshtt
Copy link
Member

@termoshtt termoshtt commented Jun 21, 2019

IIUC someone with repo access will need to enable for coveralls in order to see & record the results

I've sent auth request for coveralls. @jturner314 could you check it?

should we use the same account for all crates in this organization?

I also try to use codecov for ndarray-linalg rust-ndarray/ndarray-linalg#157 (though I still have some trouble about linking issue to LAPACK)
@termoshtt termoshtt mentioned this pull request Jun 21, 2019
Closed
@max-sixty
Copy link
Contributor Author

@max-sixty max-sixty commented Jun 24, 2019

Just seen #628! Fine to close this when the other merges.
max-sixty added 7 commits Jul 5, 2019
@max-sixty
Merge branch 'master' into coverage
Verified
This commit was signed with a verified signature.
max-sixty Maximilian Roos
GPG key ID: 3232F28BEDA66FCD Learn about signing commits
Loading status checks…
040ac58
@max-sixty
Merge branch 'master' into coverage
Verified
This commit was signed with a verified signature.
max-sixty Maximilian Roos
GPG key ID: 3232F28BEDA66FCD Learn about signing commits
0fec75e
@max-sixty
Merge branch 'master' into coverage
Verified
This commit was signed with a verified signature.
max-sixty Maximilian Roos
GPG key ID: 3232F28BEDA66FCD Learn about signing commits
ef6267b 
# Conflicts:
#	.travis.yml
#	scripts/all-tests.sh
@max-sixty
Merge branch 'master' into coverage
Verified
This commit was signed with a verified signature.
max-sixty Maximilian Roos
GPG key ID: 3232F28BEDA66FCD Learn about signing commits
1075d5e
@max-sixty
Merge branch 'master' into coverage
Verified
This commit was signed with a verified signature.
max-sixty Maximilian Roos
GPG key ID: 3232F28BEDA66FCD Learn about signing commits
ff4f58e
@max-sixty
Merge branch 'master' into coverage
Verified
This commit was signed with a verified signature.
max-sixty Maximilian Roos
GPG key ID: 3232F28BEDA66FCD Learn about signing commits
9c1ddf6
@max-sixty
Merge branch 'master' into coverage
Verified
This commit was signed with a verified signature.
max-sixty Maximilian Roos
GPG key ID: 3232F28BEDA66FCD Learn about signing commits
Loading status checks…
f89381b
@max-sixty
Copy link
Contributor Author

@max-sixty max-sixty commented Jul 25, 2020

Closing as stale; not sure whether the code on #628 was ever merged though?
@max-sixty max-sixty closed this Jul 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

[ci] Add Code Coverage
3 participants
@max-sixty @LukeMathWalker @termoshtt
You can’t perform that action at this time.