Skip to content

/ EdgeML

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

port code to tensorflow2.0 #87

Open
wants to merge 1 commit into
base: master
from
Open

port code to tensorflow2.0 #87

wants to merge 1 commit into from

Conversation

@punitvara
Copy link
Contributor

punitvara commented May 20, 2019

Compile and run code with tf2.0. Eager execution is
disabled. Tested code with python 3.5

Signed-off-by: Punit Vara punitvara@gmail.com
@punitvara
port code to tensorflow2.0
Loading status checks…
777b1b7 
Compile and run code with tf2.0. Eager execution is
disabled. Tested code with python 3.5

Signed-off-by: Punit Vara <punitvara@gmail.com>
@punitvara
Copy link
Contributor Author

punitvara commented May 20, 2019 •
edited

Either #86 or this PR should get merged. Preferably this one. @adityakusupati Can you please review this ?
@adityakusupati
Copy link
Contributor

adityakusupati commented May 24, 2019 •
edited

I will try to set it up next week and test it out. @metastableB and @harsha-simhadri any thoughts? I think this is important for tf 2.0 transition.
@adityakusupati adityakusupati requested a review from metastableB May 27, 2019
@adityakusupati
Copy link
Contributor

adityakusupati commented May 29, 2019

@punitvara , a couple of things

  1. Bonsai example runs fine, but FastCells don't
  2. Can you isolate the changes you made from the original files, this diff is very cumbersome to follow?
@punitvara
Copy link
Contributor Author

punitvara commented May 30, 2019

Ok sure. I will push in tf directory once review is done I will create new PR with tf 2.0
@metastableB
Copy link
Contributor

metastableB commented May 30, 2019

@adityakusupati I am of the opinion that we should hold out on this PR for a little bit longer till we have a clear view on what we are going to focus on; eager or static compilation. If you feel like going ahead with supporting static graphs with TF2.0, please do so. You can get a clean diff w.r.t tf/ directory by using the native diff command as explained here. You will have to go through it one file at a tile.

@punitvara Thanks for your contributions!
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@metastableB metastableB

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
@punitvara @adityakusupati @metastableB
You can’t perform that action at this time.