Skip to content
#

lightning-network

Here are 308 public repositories matching this topic...

sako0938
sako0938 commented Oct 14, 2019

Background

The binaries are built with most of the build flags already set, but when building from source you must specify which tags are desired. This is an important step to building a usable binary from source.

These flags should be listed in the docs, with what their use is for the entire system, and whether or not excluding it would break the normal function of the system.

A sect

sbtc1
sbtc1 commented Aug 18, 2019

The reference documentation does not mention the possibility of using a capitalised invoice (eg LNBC..), still most implementations in the wild seem to accept them.

There are good reasons to support capitalised invoices, like smaller QR codes.

My suggestion is to explicitely mention in the documentation that invoices should be case-independant so that implementations must allow both forms (

fjahr
fjahr commented Nov 11, 2019

I have been using the default version (old) of Bash in the latest macOS version and the color formatting in the usage example was not working as intended. I checked and the \e is not supported in the version that ships with macOS currently. However, I switched to zsh (5.7.1) and it was the same case there. Then upgraded Bash via homebrew (5.0.11) and I am still seeing the issue. I have been tryi

Gesundeslicht
Gesundeslicht commented Aug 21, 2019
  • I'm submitting a ...

    • bug report
    • feature request
    • [x ] support request
  • What is the current behavior?

Traceback (most recent call last):
File "run.py", line 22, in
sys.exit(app.start())
File "/home/Martin/node-launcher/node_launcher/gui/application.py", line 32, in start
self.node_set.start()
File "/home/Martin/node-launcher/node_

joule-extension
dmidnight
dmidnight commented Sep 5, 2019

Description of the Issue

When an invoice has expired, Joule should not allow the 'Confirm' payment button to be clicked. It should be disabled, gray, and/or show 'Expired'.

Additionally, the Reject button is no longer appropriate after expiry. It should simply be replaced with a 'Close' button.

Steps to Reproduce

Create an invoice that expires, and then leave the payment dialog

cyphernode
FrancisPouliot
FrancisPouliot commented Feb 17, 2020

This is useful for claiming pegins with elements

gettxoutproof ["txid",...] ( "blockhash" )

Returns a hex-encoded proof that "txid" was included in a block.

NOTE: By default this function only works sometimes. This is when there is an
unspent output in the utxo for this transaction. To make it always work,
you need to maintain a transaction index, using the -txindex command line option

spark-wallet
shesek
shesek commented Sep 11, 2018

Some candidates for removal that could easily be re-implemented inside Spark:

  • superagent (only used for a simple HTTP GET request, can be replaced with the built-in http module)

  • helmet (sets security headers)

  • js-yaml (only used to format objects in a human-readable manner, we don't really need yaml)

  • nanoid (secure random string generator)

  • is-ip (few-liner depende

PirosB3
PirosB3 commented Sep 23, 2018

It would be great to define a specific style guide to enforce. This would make sure we all have the same expectation when writing code, and we can also take advantage of automated tooling for lint. It looks like Airbnb, GitHub, & Google all have some open source style guide that we can take advantage of, but I don't have experience with any of them.

Would you be interested in enforcing a style

Christewart
Christewart commented May 3, 2020

https://bitcoin-s.org/docs/next/wallet/dlc#creating-the-offer

What I tried to run

➜ bin git:(8c5a11f433) ✗ ./bitcoin-s-cli createdlcoffer --oracleInfo 025acb434efb32bbf7ca7fd44b22e0f3f5570c6bc564e6059b03ba18c277054ac103f8758d7f03a65b67b90f62301a3554849bde6d00d50e965eb123398de9fd6ea7 --contractInfo c07803e32c12e100905e8d69fe38ae72f2e7a17eb7b8dc1a9bce134b0cbe920fa0860100000000005c58e41254e7a

vindard
vindard commented Feb 28, 2019

The "server address" and "macaroon/cert locations" are currently hardcoded into the script at lnd.py in a way that assumes that the script will be run in the same environment as the lnd node. Specifically for running the scripts remotely, it would be useful if there was some way to allow the user to define:

  1. a common folder location where credentials (admin.macaroon & tls.cert) are stor

Improve this page

Add a description, image, and links to the lightning-network topic page so that developers can more easily learn about it.

Curate this topic

Add this topic to your repo

To associate your repository with the lightning-network topic, visit your repo's landing page and select "manage topics."

Learn more

You can’t perform that action at this time.