Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign uptracing: support a sample rate for tracers #45891
Open
Labels
Projects
Comments
|
I'd like to start working on this. Currently reading the wiki and trying to figure out how to start, and how to be assigned. |
|
Just this comment is good enough. A pull request would be great. In general we haven't had actual contention with community contributions competing to fix the same issue. I don't anticipate that here. If somebody internally were to be working on it, it would get assigned. If you run in to any trouble or want any pointers on how to approach it, let me know. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Is your feature request related to a problem? Please describe.
Currently cockroach supports external tracing services using the zipkin or lightstep protocols. When these features are enabled, 100% of all requests are traced. This leads to serious overhead both inside of Cockroach and in the trace collection infrastructure. Tracing can provide value even at very low sampling rates. Furthermore, with new features to enable tracing on-demand for certain statement fingerprints, users could gain additional value out of an existing trace collection infrastructure.
Describe the solution you'd like
Add a cluster setting to control the sampling rate for trace collection.
Additional context
See this discussion for the original conversation #45578 (comment).